Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for HTTP Basic auth via Authorization header #167

Merged
merged 8 commits into from
Dec 11, 2015
Merged

Add support for HTTP Basic auth via Authorization header #167

merged 8 commits into from
Dec 11, 2015

Commits on Dec 9, 2015

  1. Add HTTP basic authentication.

    @lachenmayer @idan
    lachenmayer authored and idan committed Dec 9, 2015
    Configuration menu
    Copy the full SHA
    32a9043 View commit details
    Browse the repository at this point in the history

  2. Add HTTP basic authentication for Node.

    @lachenmayer @idan
    lachenmayer authored and idan committed Dec 9, 2015
    Configuration menu
    Copy the full SHA
    19cbca0 View commit details
    Browse the repository at this point in the history

  3. Documenting the HTTP Basic auth request config

    @idan
    idan committed Dec 9, 2015
    Configuration menu
    Copy the full SHA
    e270c70 View commit details
    Browse the repository at this point in the history

  4. Abandoning URL embedded identities for Basic auth 

    Use an `Authorization` header instead, which is a safer choice than URL embedded identities (aka `http://user:pass@example.com`). [Chrome 19 dropped support][chromium128323] for URL embedded identities in XMLHttpRequest for security reasons.

Added documentation note about how this will overwrite any existing `Authorization` header that the user may have set.

[chromium128323]: https://code.google.com/p/chromium/issues/detail?id=128323
    @idan
    idan committed Dec 9, 2015
    Configuration menu
    Copy the full SHA
    95df032 View commit details
    Browse the repository at this point in the history

  5. Adding tests for basic auth

    @idan
    idan committed Dec 9, 2015
    Configuration menu
    Copy the full SHA
    0d8b5b6 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2015

  1. Adding btoa polyfill

    @idan
    idan committed Dec 10, 2015
    Configuration menu
    Copy the full SHA
    3138600 View commit details
    Browse the repository at this point in the history

  2. Dropping support for auth.user/pass 

    Only accept `username` and `password` as arguments
    @idan
    idan committed Dec 10, 2015
    Configuration menu
    Copy the full SHA
    af17033 View commit details
    Browse the repository at this point in the history

  3. Polyfilling btoa where appropriate 

    Includes testing of the polyfills.
    @idan
    idan committed Dec 10, 2015
    Configuration menu
    Copy the full SHA
    603e7c8 View commit details
    Browse the repository at this point in the history