Fixing #171, don't fail on error responses with json payloads #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aukevanleeuwen
force-pushed
the
fix-for-issue-171
branch
from
fe652ed
to
f9c46c5
Compare
|
Is this closed in favor of something else that you will submit? |
|
Sorry about that, I thought I pushed your proposed fix, but apparently I forgot to commit it first ;-) I only did a reset to master and force pushed. Apparently that closes the PR. |
|
I created a new PR, since I can't reopen this one. #174 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't read responseText unless the responseType is either 'text', '' or
undefined/null.