Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing building url with hash mark #1771

Merged
merged 1 commit into from Sep 4, 2018

Conversation

@m1neral
Copy link
Contributor

commented Aug 31, 2018

This commit fix building url with hash map (fragment identifier) when parameters are present: they must not be added after #, because client cut everything after #

@axe312ger
Copy link
Contributor

left a comment

LGTM

@m1neral

This comment has been minimized.

Copy link
Contributor Author

commented Sep 4, 2018

@RikkiGibson @aguynamedben @Khaledgarbaya : please review this pull request, it's small, but important! thank you!

@Khaledgarbaya Khaledgarbaya merged commit 81eaa3d into axios:master Sep 4, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.