Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing building url with hash mark #1771

merged 1 commit into from Sep 4, 2018


Copy link

@m1neral m1neral commented Aug 31, 2018

This commit fix building url with hash map (fragment identifier) when parameters are present: they must not be added after #, because client cut everything after #

Copy link

@axe312ger axe312ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Copy link
Contributor Author

m1neral commented Sep 4, 2018

@RikkiGibson @aguynamedben @Khaledgarbaya : please review this pull request, it's small, but important! thank you!

@Khaledgarbaya Khaledgarbaya merged commit 81eaa3d into axios:master Sep 4, 2018
@axios axios locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants