-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix params
merging
#2196
Fix params
merging
#2196
Conversation
Nice job @zackseuberling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emilyemorehouse, I tested this one locally and it seems good. I do agree with @zackseuberling that there has been a change from 0.18 to 0.19. You can run it in over here and see the behavior is different.
0.19.0 is breaking our services. The root cause appears to be what this is fixing. What kind of timeline on a merge and release? 🤓🍻 |
@kodmunki I cannot merge the changes, we will need to wait for @emilyemorehouse. I'm sure it will be done soon. |
I think maybe this PR should be passed alongside this one: #2207 because more than one BC was induced by |
plz merge it |
Do we have an update as to when this is getting merged? |
I would just like to say that we (at quasarframework) are still recommending that people pin 0.18.1, and I have to agree that @code-a-cola is right - it would be good to update us on this issue / PR. |
@emilyemorehouse .. thanks for your work on this project .. it qould be great and neefull to see this pr merged! :-) |
since they are taking a really long time to merge the fix over at axios/axios#2196
I ran @zackseuberling your test breaks against master, so PR 2207 seemed to be solving another issue:
|
@zackseuberling , code is updated, please resolve the conflicts, thanks! |
c035a68
to
49e067a
Compare
would you mind adding tests to this change? |
and fixing the existing tests |
@yasuf I can no longer get the test suite to run for me, so it is quite hard for me to fix or change any tests. I rebased and force-updated so I lost the changes to tests I had written earlier. |
Closed in favor of #2656. Cheers. |
Fixes bug introduced in 0.19.0 where request params are not being merged correctly with default instance params. See bug #2190 for more information
According to the documentation:
Tests were failing because of the change to merge params, so hopefully my update to the tests is correct … and passes