Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom HTTP status code error ranges #308

Merged
merged 3 commits into from
Apr 26, 2016
Merged

Allow custom HTTP status code error ranges #308

merged 3 commits into from
Apr 26, 2016

Conversation

nickuraltsev
Copy link
Member

Fixed #41

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 91.884% when pulling 91d823f on nickuraltsev:validate-status into 093593c on mzabriskie:master.

@nickuraltsev nickuraltsev mentioned this pull request Apr 22, 2016
Merged
@eilgin
Copy link

eilgin commented Apr 26, 2016

excellent, i was thinking about doing that since our REST API does send 404 that shouldn't be treated as an error.

So definitely 👍

@mzabriskie mzabriskie merged commit fa9444e into axios:master Apr 26, 2016
@lazharichir
Copy link

can't wait for this to be fixed as my backend also returns 400 that shouldn't trigger errors but simply a *_REJECTED so I can handle it / translate it for the user on the frontend.

@axios axios locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't throw error / catch on 400-level responses
5 participants
@nickuraltsev @coveralls @eilgin @lazharichir @mzabriskie