Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix axios.delete ignores config.data #3282

Merged
merged 2 commits into from Oct 1, 2020

Conversation

@chinesedfan
Copy link
Collaborator

@chinesedfan chinesedfan commented Sep 12, 2020

Fixes #3220. As explained in #3220 (comment).

@cuongdevjs
Copy link

@cuongdevjs cuongdevjs commented Sep 16, 2020

How long this pr merged and release?

@ngajhede
Copy link

@ngajhede ngajhede commented Sep 18, 2020

Yes please. This is currently breaking parts of our application.

A temporary solution is to use axios.request:
axios.request({data, url, method: 'delete'});

Copy link
Collaborator

@jasonsaayman jasonsaayman left a comment

Looks good 👍 I think this will help us with potentially breaking changes in the future.

Copy link
Collaborator

@jasonsaayman jasonsaayman left a comment

👍

@jasonsaayman jasonsaayman merged commit fa36737 into axios:master Oct 1, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@DanielIndie95
Copy link

@DanielIndie95 DanielIndie95 commented Oct 6, 2020

@jasonsaayman why isnt that released yet? As I can see that the latest version is still 0.20.0

@MwumLi
Copy link

@MwumLi MwumLi commented Oct 12, 2020

@jasonsaayman why isnt that released yet? npm version not match github tag

@lifesboy
Copy link

@lifesboy lifesboy commented Oct 14, 2020

When will this version be released, please?

@pholleyad
Copy link

@pholleyad pholleyad commented Oct 15, 2020

Adding another request for this to be released as well. Thanks @ngajhede for the workaround!

@jasonsaayman
Copy link
Collaborator

@jasonsaayman jasonsaayman commented Oct 16, 2020

Hi All,

I am not able to do the release, only Emily can, I have spoken to her and I think we should see the release over the weekend.

Thanks

@rlightner
Copy link

@rlightner rlightner commented Oct 21, 2020

@jasonsaayman
Copy link
Collaborator

@jasonsaayman jasonsaayman commented Oct 22, 2020

I have asked again today to see when the release will happen, will update this thread as soon as I know whats going on.

@jasonsaayman
Copy link
Collaborator

@jasonsaayman jasonsaayman commented Oct 23, 2020

Hi,

Version 0.21.0 has been released 🎉 please use that and let us know if that solves your issue.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

9 participants
You can’t perform that action at this time.