Moving default adapter to global defaults #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| response.headers, | ||
| var adapter = config.adapter || defaults.adapter; | ||
|
|
||
| return adapter(config).then(function onAdapterResolution(response) { |
There was a problem hiding this comment.
What happens if config.adapter or defaults.adapter end up not being a function? In the previous if/else for selecting an adapter you always had a fallback in case config.adapter supplied something invalid.
There was a problem hiding this comment.
I think we better detect it at this point rather than falling back to any other implementation without errors. That way is much harder to debug, don't you think?
There was a problem hiding this comment.
I agree with @rubennorte. Silently falling back to another adapter is not going to make anyone's life easier.
|
Any updates with this one? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I expect that this PR will make easier for the developers to debug which is the default adapter for a given environment and also to decorate them with any additional functionality.