New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make sure all ListModelMixin views considered as list view #306
Conversation
Makes sense, thanks. It would be great if you would also add a test for this somewhere, to show the intention and prevent future regressions. |
sure, then i'll need to add new view and the url. i'll add endpoint that retrieve list of all objects that related to certain user with url |
You can add it anywhere you want, there's no real structure to the test project view, most of them don't even work. |
39ebbb0
to
351a11c
Compare
351a11c
to
405f792
Compare
@axnsan12 added the test for this fix, please check again. thank you |
Looks OK, thanks! |
@axnsan12 is this issue already covered by your last commit? |
The last commit was targeted at #330. I'll be meeting this when I get the chance to rebase it on the latest master (or if you can do that). Sorry for being so slow about this. |
I meant #331 |
7c67df3
to
4c78a68
Compare
trigger too many tests, please re-run it. thanks |
so i realize this weird behavior because i have a view that inherit
generics.ListCreateAPIView
and rendered swagger doesn't add pagination to the response sample for that view. Found that its because the URL end with parameter.TLDR:
class GroupMemberListAPIView(generics.ListCreateAPIView)
+path('connections/group/<int:group_id>/', GroupMemberListAPIView.as_view())
= not considered as list view