feat: add is_list option to view action method #331
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I struggled a day try to add drf-yasg for a exists project.
First I found drf-yasg generate unintented schema.
our TopicViewSet as follows:( one Topic have many Posts)
in order to make drf-yasg generate right schema for posts actions. I have debug a lot and read drf-yasg's source code.
and I found:
detail=True
can't set toFalse
because We need thepk
parameter.detail=True
then we can't return paginated response schema.My finally code was as below:
and I have to midify the drf-yasg source code, I think it would be very useful to add optional
is_list
flag for view action method.I've checked our project,there are many places, I need to use
is_list
option to make drf-yasg work correctly.