New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[npm-installer] support more than tar.gz #226
Comments
We have now forked/vendored binary-install, and so we have the ability to fix this. The JS code that needs to change is here: cargo-dist/cargo-dist/templates/installer/npm/binary-install.js Lines 83 to 91 in e64776d
Given the above researach I think we should just invoke on-end-user-system CLIs for greater support. This would make the npm installer as reliable as the shell/powershell installers. Relevant shell code: cargo-dist/cargo-dist/templates/installer/installer.sh.j2 Lines 209 to 220 in e64776d
Relevant Powershell code: cargo-dist/cargo-dist/templates/installer/installer.ps1.j2 Lines 166 to 177 in e64776d
|
cargo-dist currently lets you select your binary archive format:
But the npm installer can only handle .tar.gz! This is a limitation inherited from the binary-install npm package (yes the "fork" is the Real One), which in turn inherits the limitation from the npm tar package which in turn inherits the limitation from "node-js bundles a gzip encoder/decoder and that's all we use".
As a workaround I will be making the new interactive UX default to .tar.gz compression if you enable npm installers, but we should really deal with by fixing/forking/ditching binary-install.
The text was updated successfully, but these errors were encountered: