Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(config): remove deprecated, move sync_txs_chunk_size out from consensus #1333

Merged
merged 1 commit into from Aug 17, 2023

Conversation

yangby-cryptape
Copy link
Collaborator

@yangby-cryptape yangby-cryptape commented Aug 17, 2023

What this PR does / why we need it?

This PR refactor config according to #1307 (comment).

A field in consensus section doesn't affect the consensus.
Its readability is poor, and it's not easy to understand.

What is the impact of this PR?

Breaking Change:

  • Configurations.
    • Remove crosschain_contract_address, wckb_contract_address and executor.light.
    • The consensus section will be renamed to synchronization.
CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Cargo Clippy
  • Coverage Test
  • E2E Tests
  • Code Format
  • Unit Tests
  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

CI Description

CI Name Description
Chaos CI Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy Run cargo clippy --all --all-targets --all-features
Coverage Test Get the unit test coverage report
E2E Test Run end-to-end test to check interfaces
Code Format Run cargo +nightly fmt --all -- --check and cargo sort -gwc
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

@yangby-cryptape yangby-cryptape requested a review from a team as a code owner August 17, 2023 03:22
@yangby-cryptape

This comment was marked as off-topic.

@axon-bot
Copy link

axon-bot bot commented Aug 17, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • E2E Tests
  • Unit Tests

Please check ci test results later.

@KaoImin KaoImin added this pull request to the merge queue Aug 17, 2023
Merged via the queue into main with commit 4cf06e5 Aug 17, 2023
32 checks passed
@yangby-cryptape yangby-cryptape deleted the yangby/refactor/config-toml branch August 17, 2023 07:50
KaoImin pushed a commit that referenced this pull request Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants