Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: change the rlp codec of Hex #1382

Merged
merged 2 commits into from Aug 30, 2023
Merged

refactor!: change the rlp codec of Hex #1382

merged 2 commits into from Aug 30, 2023

Conversation

KaoImin
Copy link
Contributor

@KaoImin KaoImin commented Aug 29, 2023

What this PR does / why we need it?

This PR change the rlp codec of Hex.
The previous implement convert Hex as String and the current implement convert it asVec<u8>. This saves half of the space, however, it is a breaking change.

What is the impact of this PR?

⚠️ This is a breaking change.

PR relation:

CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • E2E Tests
  • Code Format
  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

CI Description

CI Name Description
Chaos CI Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy Run cargo clippy --all --all-targets --all-features
Coverage Test Get the unit test coverage report
E2E Test Run end-to-end test to check interfaces
Code Format Run cargo +nightly fmt --all -- --check and cargo sort -gwc
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

@KaoImin KaoImin requested a review from a team as a code owner August 29, 2023 06:45
@KaoImin KaoImin requested review from ashuralyk, Simon-Tl, Flouse and yangby-cryptape and removed request for ashuralyk August 29, 2023 06:45
@KaoImin

This comment was marked as off-topic.

@axon-bot

This comment was marked as outdated.

@KaoImin

This comment was marked as off-topic.

1 similar comment
@yangby-cryptape

This comment was marked as off-topic.

@KaoImin

This comment was marked as off-topic.

@github-actions

This comment was marked as outdated.

@Flouse Flouse linked an issue Aug 29, 2023 that may be closed by this pull request
@Flouse Flouse requested review from driftluo and removed request for Simon-Tl August 29, 2023 13:00
@KaoImin

This comment was marked as off-topic.

@github-actions

This comment was marked as outdated.

@KaoImin

This comment was marked as off-topic.

@github-actions
Copy link

CI tests run on commit:

CI test list:

  • E2E Tests
  • Web3 Compatible Tests

Please check ci test results later.

@KaoImin KaoImin enabled auto-merge August 30, 2023 09:54
@KaoImin KaoImin added this pull request to the merge queue Aug 30, 2023
Merged via the queue into main with commit 6548ea0 Aug 30, 2023
27 checks passed
@KaoImin KaoImin deleted the refactor-hex-codec branch September 1, 2023 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI failed since #1371 Store bytes in memory rather than hex string
4 participants