Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fetch data by prefix will get more data than needed #71

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

wenyuanhust
Copy link
Contributor

@wenyuanhust wenyuanhust commented Sep 15, 2023

The IteratorMode::From mode starts the iterator at the first key that is greater than or equal to the provided key.
rust-rocksdb/rust-rocksdb#370
If there are keys that sort after your prefix but are not part of it, they will still be included in the iteration.
https://bleepcoder.com/rust-rocksdb/378811240/the-prefix-iterator-behaves-weirdly

storage/src/smt/utils.rs Outdated Show resolved Hide resolved
@wenyuanhust wenyuanhust changed the title bug: fetch data by prefix will get more data than needed bugfix: fetch data by prefix will get more data than needed Sep 15, 2023
@KaoImin KaoImin changed the title bugfix: fetch data by prefix will get more data than needed fix: fetch data by prefix will get more data than needed Sep 15, 2023
@wenyuanhust wenyuanhust added this pull request to the merge queue Sep 15, 2023
Merged via the queue into axonweb3:main with commit f848355 Sep 15, 2023
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants