Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: FormatItem.AsSpan() #304

Merged
merged 1 commit into from
Aug 5, 2022
Merged

Fixed: FormatItem.AsSpan() #304

merged 1 commit into from
Aug 5, 2022

Conversation

axunonb
Copy link
Member

@axunonb axunonb commented Aug 5, 2022

  • Fixed: FormatItem.AsSpan() now returns ReadOnlySpan.Empty for EndIndex <= StartIndex
  • Partly disable SonarClooud warning S3267
  • Updated comments and xmldoc
  • Refactored IConvertible unit tests

* Fixed: FormatItem.AsSpan() now returns ReadOnlySpan<char>.Empty for EndIndex <= StartIndex
* Partly disable SonarClooud warning S3267
* Updated comments and xmldoc
@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #304 (f513ab2) into main (ce9f034) will not change coverage.
The diff coverage is 100%.

@@         Coverage Diff         @@
##           main   #304   +/-   ##
===================================
  Coverage    96%    96%           
===================================
  Files        91     91           
  Lines      3184   3184           
===================================
  Hits       3068   3068           
  Misses      116    116           
Impacted Files Coverage Δ
src/SmartFormat/Core/Parsing/Format.cs 96% <ø> (ø)
src/SmartFormat/Core/Sources/Source.cs 100% <ø> (ø)
src/SmartFormat/Extensions/DefaultFormatter.cs 100% <ø> (ø)
src/SmartFormat/Extensions/ListFormatter.cs 98% <ø> (ø)
src/SmartFormat/SmartFormatter.cs 97% <ø> (ø)
src/SmartFormat/Core/Parsing/FormatItem.cs 100% <100%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@axunonb axunonb merged commit 0f8dbd1 into axuno:main Aug 5, 2022
@axunonb axunonb deleted the pr-format-item branch August 5, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant