Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ListFormatter #305

Merged
merged 1 commit into from
Aug 6, 2022
Merged

Refactor ListFormatter #305

merged 1 commit into from
Aug 6, 2022

Conversation

axunonb
Copy link
Member

@axunonb axunonb commented Aug 6, 2022

  • Set the ParentPlaceholder property for item Formats
  • Use PooledObject<T> where possible, so objects will be returned to ObjectPool also in case of exceptions

@sonarcloud
Copy link

sonarcloud bot commented Aug 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Aug 6, 2022

Codecov Report

Merging #305 (a7089c1) into main (0f8dbd1) will increase coverage by 0%.
The diff coverage is 100%.

@@         Coverage Diff         @@
##           main   #305   +/-   ##
===================================
  Coverage    96%    96%           
===================================
  Files        91     91           
  Lines      3184   3186    +2     
===================================
+ Hits       3068   3070    +2     
  Misses      116    116           
Impacted Files Coverage Δ
src/SmartFormat/Extensions/ListFormatter.cs 98% <100%> (+<1%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@axunonb axunonb merged commit 85c4430 into main Aug 6, 2022
@axunonb axunonb deleted the pr-refactor-listformatter branch August 6, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant