Ignore bools in plurals formatter. #306
Conversation
| @@ -113,7 +113,7 @@ public bool TryEvaluateFormat(IFormattingInfo formattingInfo) | |||
| // We can format numbers, and IEnumerables. For IEnumerables we look at the number of items | |||
| // in the collection: this means the user can e.g. use the same parameter for both plural and list, for example | |||
| // 'Smart.Format("The following {0:plural:person is|people are} impressed: {0:list:{}|, |, and}", new[] { "bob", "alice" });' | |||
| if (current is IConvertible convertible) | |||
| if (current is IConvertible convertible && current is not bool) | |||
There was a problem hiding this comment.
We do still consider Enums which we did not previously although that seemed fine to me.
There was a problem hiding this comment.
Would be nice to have a unit test for that case 😉
There was a problem hiding this comment.
Guess, I oversaw an my mobile, that the test is already there.
Thanks a lot for submitting the fix.
(Merged current main, before the squash & merge.)
Codecov Report
@@ Coverage Diff @@
## main #306 +/- ##
===================================
Coverage 96% 96%
===================================
Files 91 91
Lines 3184 3186 +2
===================================
+ Hits 3068 3070 +2
Misses 116 116
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| @@ -113,7 +113,7 @@ public bool TryEvaluateFormat(IFormattingInfo formattingInfo) | |||
| // We can format numbers, and IEnumerables. For IEnumerables we look at the number of items | |||
| // in the collection: this means the user can e.g. use the same parameter for both plural and list, for example | |||
| // 'Smart.Format("The following {0:plural:person is|people are} impressed: {0:list:{}|, |, and}", new[] { "bob", "alice" });' | |||
| if (current is IConvertible convertible) | |||
| if (current is IConvertible convertible && current is not bool) | |||
There was a problem hiding this comment.
Guess, I oversaw an my mobile, that the test is already there.
Thanks a lot for submitting the fix.
(Merged current main, before the squash & merge.)
I introduced a small bug in my last PR. The plurals formatter will now also consider bools which changes the behaviors when it is using auto detect. This was causing some of our tests to fail because we had an Arabic language running at the time which produces different plurals.