Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for nesting formats in LocalizationFormatter #350

Merged
merged 2 commits into from
Sep 9, 2023

Conversation

zacateras
Copy link
Contributor

No description provided.

@zacateras zacateras force-pushed the pr-localization-formatter-nesting branch from 350f4cd to 1e43acf Compare August 29, 2023 14:37
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage: 100% and no project coverage change.

Comparison is base (2bb777c) 96% compared to head (028b4c8) 96%.

❗ Current head 028b4c8 differs from pull request most recent head baf7fd3. Consider uploading reports for the commit baf7fd3 to get more accurate results

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #350   +/-   ##
===================================
  Coverage    96%    96%           
===================================
  Files        91     91           
  Lines      3190   3198    +8     
===================================
+ Hits       3076   3084    +8     
  Misses      114    114           
Files Changed Coverage Δ
...rc/SmartFormat/Extensions/LocalizationFormatter.cs 100% <100%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zacateras zacateras force-pushed the pr-localization-formatter-nesting branch from f9013f9 to baf7fd3 Compare September 8, 2023 21:00
@axunonb axunonb merged commit 6a395ec into axuno:main Sep 9, 2023
3 checks passed
@axunonb
Copy link
Member

axunonb commented Sep 9, 2023

Nice, thank you!

@zacateras zacateras deleted the pr-localization-formatter-nesting branch September 10, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants