Issue #598, Part 1.

[HoshinoTented]

This PR should:

• Supports any licit ParamShape (whatever explicit or implicit)
• Desugar [ {O} ] correctly (or reject it).
• Handle cons with implicit arguments correctly.

Questions

• Should we support [ {expr/pattern} ] ?
  • We do not support
    • When do we reject this expression/pattern? Parsing (in .bnf)? Producing (in AyaGKProducer)?
  • We do support
    • How to handle [ (S n) as m ] where | cons {A} (List A)
    • Similarly, how to handle [ {S n} as m ] where | cons (A) (List A)

[codecov]

Codecov Report

Merging #599 (c484f79) into main (5ecd681) will decrease coverage by 0.01%.
The diff coverage is 76.47%.

@@             Coverage Diff              @@
##               main     #599      +/-   ##
============================================
- Coverage     80.54%   80.53%   -0.02%     
- Complexity     2750     2752       +2     
============================================
  Files           224      224              
  Lines          8637     8645       +8     
  Branches       1071     1073       +2     
============================================
+ Hits           6957     6962       +5     
- Misses         1097     1098       +1     
- Partials        583      585       +2     

Impacted Files	Coverage Δ
.../src/main/java/org/aya/core/repr/ShapeMatcher.java	69.35% <50.00%> (-2.32%)	⬇️
...ase/src/main/java/org/aya/core/repr/CodeShape.java	54.16% <80.00%> (+9.72%)	⬆️
base/src/main/java/org/aya/core/repr/AyaShape.java	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[ice1000]

Desugar [ {O} ] correctly (or reject it).

I propose to reject it

[ice1000]

Licit

[ice1000]

Exp, Imp

[ice1000]

Alternative: Explicit.Yes, Explicit.No, Explicit.Unsure

[HoshinoTented]

The base made a big change, close.

[ice1000]

RIP