Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing Implicit Argument in List Ctor #634

Merged
merged 3 commits into from
Nov 6, 2022
Merged

Allowing Implicit Argument in List Ctor #634

merged 3 commits into from
Nov 6, 2022

Conversation

HoshinoTented
Copy link
Contributor

A re-development of #599 on the new base.

@codecov
Copy link

codecov bot commented Nov 6, 2022

Codecov Report

Merging #634 (44ef4ef) into main (2c67240) will decrease coverage by 0.00%.
The diff coverage is 76.47%.

@@             Coverage Diff              @@
##               main     #634      +/-   ##
============================================
- Coverage     79.11%   79.10%   -0.01%     
- Complexity     2818     2820       +2     
============================================
  Files           254      254              
  Lines          9107     9128      +21     
  Branches       1111     1112       +1     
============================================
+ Hits           7205     7221      +16     
- Misses         1291     1294       +3     
- Partials        611      613       +2     
Impacted Files Coverage Δ
.../src/main/java/org/aya/core/repr/ShapeMatcher.java 68.85% <0.00%> (-2.82%) ⬇️
...ase/src/main/java/org/aya/core/repr/CodeShape.java 52.38% <62.50%> (+7.93%) ⬆️
base/src/main/java/org/aya/concrete/Pattern.java 90.00% <78.57%> (-4.74%) ⬇️
base/src/main/java/org/aya/core/repr/AyaShape.java 100.00% <100.00%> (ø)
...src/main/java/org/aya/cli/parse/AyaGKProducer.java 88.93% <100.00%> (+0.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@HoshinoTented HoshinoTented self-assigned this Nov 6, 2022
@ice1000
Copy link
Member

ice1000 commented Nov 6, 2022

I believe that this reveals a serious problem in the design of Pattern ast. We may need to decouple the implicitness with the pattern itself

Copy link
Member

@ice1000 ice1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@ice1000 ice1000 added this to the v0.23 milestone Nov 6, 2022
bors bot added a commit that referenced this pull request Nov 6, 2022
634: Allowing Implicit Argument in List Ctor r=ice1000 a=HoshinoTented

A re-development of #599 on the new base.

Co-authored-by: HoshinoTented <hoshinotented@qq.com>
@bors
Copy link
Contributor

bors bot commented Nov 6, 2022

This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried.

Additional information:

{"message":"All comments must be resolved.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@imkiva
Copy link
Member

imkiva commented Nov 6, 2022

I believe that this reveals a serious problem in the design of Pattern ast. We may need to decouple the implicitness with the pattern itself

Recall the wired parsing code in AyaGKProducer, I can't agree more! We may need a Arg<Pat> (and also Arg<Pattern>)

@imkiva
Copy link
Member

imkiva commented Nov 6, 2022

bors merge

@bors
Copy link
Contributor

bors bot commented Nov 6, 2022

Build succeeded:

@bors bors bot merged commit e3c2856 into main Nov 6, 2022
@bors bors bot deleted the im-list-shape branch November 6, 2022 11:22
@ice1000 ice1000 mentioned this pull request Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants