Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more useless subst #623

Merged
merged 4 commits into from
Nov 2, 2022
Merged

No more useless subst #623

merged 4 commits into from
Nov 2, 2022

Conversation

HoshinoTented
Copy link
Contributor

@HoshinoTented HoshinoTented commented Nov 1, 2022

The subst of parameters of Ctor now disappear after tyck that Pat.Ctor. For example:

open data Nat
| O
| S (_1 : Nat)

def justMatch (m n : Nat) : Nat
| O, n => O
| S m', n => m'

There is a subst _1 |-> m' when we tyck the n pattern in | S m', n => m', which is useless.

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #623 (f677dcd) into main (a9f7355) will increase coverage by 0.00%.
The diff coverage is 96.55%.

❗ Current head f677dcd differs from pull request most recent head c91c451. Consider uploading reports for the commit c91c451 to get more accurate results

@@            Coverage Diff            @@
##               main     #623   +/-   ##
=========================================
  Coverage     79.96%   79.97%           
- Complexity     2815     2818    +3     
=========================================
  Files           229      229           
  Lines          8906     8920   +14     
  Branches       1097     1097           
=========================================
+ Hits           7122     7134   +12     
- Misses         1195     1197    +2     
  Partials        589      589           
Impacted Files Coverage Δ
base/src/main/java/org/aya/tyck/pat/PatTycker.java 91.10% <96.15%> (+0.39%) ⬆️
base/src/main/java/org/aya/core/visitor/Subst.java 90.47% <100.00%> (+0.47%) ⬆️
...ase/src/main/java/org/aya/tyck/pat/TypedSubst.java 100.00% <100.00%> (ø)
...main/java/org/aya/cli/library/LibraryCompiler.java 82.51% <0.00%> (-1.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ice1000 ice1000 added this to the v0.23 milestone Nov 2, 2022
@ice1000
Copy link
Member

ice1000 commented Nov 2, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 2, 2022

Build succeeded:

@bors bors bot merged commit 7889b52 into main Nov 2, 2022
@bors bors bot deleted the fix-patSubst branch November 2, 2022 02:08
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants