Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Prop pattern matching tyck #629

Merged
merged 8 commits into from
Nov 4, 2022
Merged

Implement Prop pattern matching tyck #629

merged 8 commits into from
Nov 4, 2022

Conversation

mio-19
Copy link
Contributor

@mio-19 mio-19 commented Nov 4, 2022

TODO:

  • Generate ErasedTerm for pattern matching

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Merging #629 (6722eb4) into main (c91c451) will decrease coverage by 0.82%.
The diff coverage is 82.60%.

@@             Coverage Diff              @@
##               main     #629      +/-   ##
============================================
- Coverage     79.97%   79.14%   -0.83%     
+ Complexity     2816     2763      -53     
============================================
  Files           229      231       +2     
  Lines          8919     9107     +188     
  Branches       1096     1114      +18     
============================================
+ Hits           7133     7208      +75     
- Misses         1197     1290      +93     
- Partials        589      609      +20     
Impacted Files Coverage Δ
...main/java/org/aya/cli/library/LibraryCompiler.java 82.51% <0.00%> (ø)
base/src/main/java/org/aya/tyck/env/LocalCtx.java 84.09% <50.00%> (+5.02%) ⬆️
base/src/main/java/org/aya/tyck/ExprTycker.java 83.63% <100.00%> (+0.17%) ⬆️
base/src/main/java/org/aya/tyck/StmtTycker.java 87.68% <100.00%> (ø)
base/src/main/java/org/aya/tyck/pat/PatTycker.java 90.94% <100.00%> (-0.12%) ⬇️
...src/main/java/org/aya/tyck/pat/PatternProblem.java 87.30% <100.00%> (+0.86%) ⬆️
...in/java/org/aya/concrete/visitor/ExprConsumer.java 57.14% <0.00%> (-42.86%) ⬇️
cli/src/main/java/org/aya/cli/repl/AyaRepl.java 68.75% <0.00%> (-11.69%) ⬇️
base/src/main/java/org/aya/core/visitor/Subst.java 80.95% <0.00%> (-9.53%) ⬇️
...c/main/java/org/aya/core/visitor/BetaExpander.java 64.21% <0.00%> (-8.41%) ⬇️
... and 44 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

HoshinoTented
HoshinoTented previously approved these changes Nov 4, 2022
Copy link
Member

@ice1000 ice1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to change something

@ice1000 ice1000 added this to the v0.23 milestone Nov 4, 2022
@ice1000 ice1000 added the prop Universe of propositions label Nov 4, 2022
@ice1000
Copy link
Member

ice1000 commented Nov 4, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 4, 2022

Build succeeded:

@bors bors bot merged commit c474a8a into main Nov 4, 2022
@bors bors bot deleted the prop branch November 4, 2022 23:54
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prop Universe of propositions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants