Fix CI errors #398
Merged
Fix CI errors #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aya-rs-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
vadorovsky
force-pushed
the
fix-miri
branch
4 times, most recently
from
db6e67b
to
26b27c7
Compare
vadorovsky
force-pushed
the
fix-miri
branch
3 times, most recently
from
0468dbc
to
faddbce
Compare
dave-tucker
requested changes
Sep 30, 2022
vadorovsky
force-pushed
the
fix-miri
branch
2 times, most recently
from
fc11055
to
b5ef9c6
Compare
Instead, operate on byte slices if possible. That's the first step in getting rid of miri warnings about Strict Provenance[0]. [0] https://doc.rust-lang.org/nightly/std/ptr/index.html#strict-provenance Signed-off-by: Michal Rostecki <vadorovsky@gmail.com>
`override_syscall` performs integer-to-pointer conversion. This is considered harmful on the newest Rust nightly which provides `ptr::from_exposed_addr`, but there is no other way on Rust stable than doing `as *const T`, which is what miri is unhappy about. Signed-off-by: Michal Rostecki <vadorovsky@gmail.com>
libbpf 1.0 doesn't support multimaps defined in `maps` section, it supports only BTF maps. At the same time, we already test multimaps loading with the Rust example (`integration-ebpf/src/bpf/map_test.rs`), so we can just remove the failing C test. Signed-off-by: Michal Rostecki <vadorovsky@gmail.com>
Merged
alessandrod
approved these changes
Oct 3, 2022
dave-tucker
added
aya
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
miri has the a warning about integer-to-pointer casts, due to the new Strict Provenance API[0] in Rust nightly which provides methods like
from_exposed_addrand compiler intrinsic to do it safely.We could fix some of the warnings by operating on byte slices instead of pointers. However, sometimes we only have an integer. There is a crate providing the Strict Provenance API methods[1], but it does integer-to-pointer casts itself, so miri issues warnings anyway.
Therefore we need to disable this check for now.
The other CI failure to fix was incompability of integration tests with libbpf 1.0 (we were using legacy maps instead of BTF maps).
[0] https://doc.rust-lang.org/nightly/std/ptr/index.html#strict-provenance
[1] https://crates.io/crates/sptr
Signed-off-by: Michal Rostecki vadorovsky@gmail.com