Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aya-log: Add format hints for MAC addresses #436

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

vadorovsky
Copy link
Member

@vadorovsky vadorovsky commented Nov 7, 2022

Add {:mac} (for lower-case hex representation) and {:MAC} (for upper-case hex representation) format hints for the [u8; 6] type, which is the standard one in Linux to store physical addresses in.

Tested with: https://github.com/vadorovsky/aya-examples/tree/main/xdp-mac

Signed-off-by: Michal Rostecki vadorovsky@gmail.com

@netlify
Copy link

netlify bot commented Nov 7, 2022

Deploy Preview for aya-rs-docs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2223ab8
🔍 Latest deploy log https://app.netlify.com/sites/aya-rs-docs/deploys/63694be0b847360008bd9232
😎 Deploy Preview https://deploy-preview-436--aya-rs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Add `{:mac}` (for lower-case hex representation) and `{:MAC}` (for
upper-case hex representation) format hints for the `[u8; 6]` type,
which is the standard one in Linux to store physical addresses in.

Tested with: https://github.com/vadorovsky/aya-examples/tree/main/xdp-mac

Signed-off-by: Michal Rostecki <vadorovsky@gmail.com>
Copy link
Member

@dave-tucker dave-tucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dave-tucker dave-tucker merged commit 3adb9b0 into aya-rs:main Nov 14, 2022
@vadorovsky vadorovsky deleted the aya-log-mac-addr branch November 14, 2022 14:37
@dave-tucker dave-tucker added feature A PR that implements a new feature or enhancement aya-log Relating to aya-log labels Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aya-log Relating to aya-log feature A PR that implements a new feature or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants