Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tracefs mount point select function #471

Merged
merged 2 commits into from
Jan 26, 2023

Conversation

banditopazzo
Copy link
Contributor

This PR would to improve the access to tracefs.

This is implemented with a single check to determine if the tracefs is mounted or not. It checks in two known locations, in order of priority:

  1. /sys/kernel/tracing
  2. /sys/kernel/debug/tracing

Most of the systems have both tracefs and debugfs mounted, but in some hardened systems the kernel is compiled without debugfs or simply not mounted. Android documentation for example has a warning for debugfs in user builds.

@netlify
Copy link

netlify bot commented Dec 22, 2022

Deploy Preview for aya-rs-docs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 48fdf5a
🔍 Latest deploy log https://app.netlify.com/sites/aya-rs-docs/deploys/63d27b75d2b070000855a60a
😎 Deploy Preview https://deploy-preview-471--aya-rs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Collaborator

@alessandrod alessandrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Just a few minor comments

aya/src/programs/utils.rs Outdated Show resolved Hide resolved
aya/src/programs/mod.rs Outdated Show resolved Hide resolved
aya/src/programs/trace_point.rs Outdated Show resolved Hide resolved
Copy link
Member

@vadorovsky vadorovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alessandrod are you happy with the current state of this PR?

Copy link
Collaborator

@alessandrod alessandrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please rebase on main so we can get CI green?

@banditopazzo
Copy link
Contributor Author

done

@alessandrod alessandrod self-requested a review January 26, 2023 13:45
@alessandrod alessandrod merged commit 7e5637b into aya-rs:main Jan 26, 2023
@banditopazzo banditopazzo deleted the tracefs_mount_select branch January 27, 2023 13:18
@dave-tucker dave-tucker added aya This is about aya (userspace) fix A PR that is a small change or fixes a bug labels Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aya This is about aya (userspace) fix A PR that is a small change or fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants