aya: deny various allow-by-default lints #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aya-rs-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hey @alessandrod, this pull request changes the Aya Public API and requires your review. |
mergify
bot
added
api/needs-review
tamird
force-pushed
the
lints
branch
2 times, most recently
from
12d908d
to
7a879d9
Compare
Notably: - clippy::use_self: replaced many T with Self. - single_use_lifetimes: removed some single use lifetimes. - unreachable_pub: removed some unreachable pub items. - unused_crate_dependencies: removed unused futures,parking_lot deps. - unused_qualifications: found a potential `crate` vs `$crate` bug. - let_underscore_drop: not enabled, seems to trigger false positives. - missing_copy_implementations: not enabled, unclear if we want this. - unsafe_op_in_unsafe_fn: not enabled, unclear if we want this. - unused_results: not enabled, needs many fixes (but I think wanted).
dave-tucker
approved these changes
Aug 24, 2023
Comment on lines
+503
to
+504
| #[allow(trivial_numeric_casts)] | ||
| let fd = fd as RawFd; |
There was a problem hiding this comment.
I assume this will go away with when bpf_create_map returns an OwnedFd?
There was a problem hiding this comment.
Yep, though it might end up relocating elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notably:
cratevs$cratebug.