ebpf: Limit args access to kprobe/uprobe and ret access to kretprobe/uretprobe
#912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aya-rs-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
mergify
bot
added
aya-bpf
|
Hey! Sorry for the delay in reviewing this! Have had a busy couple of weeks but I plan to take a look in the next couple of days :) |
|
Sorry it took so long! Looks great, if you mark as ready for review I'll approve. Also CI is failing, so please fix that. |
Created retprobe.rs to hold RetProbeContext and moved the ret from ProbeContext in probe.rs into RetProbeContext. Now, only kprobe (which uses ProbeContext) can access args, and kretprobe (which uses RetProbeContext) can access ret. Fixes: aya-rs#700
Added logic in expand function in both kprobe.rs and uprobe.rs for valid macros. Now, kprobe & uprobe proc macros only accept ProbeContext, and kretprobe & uretprobe only accept RetProbeContext. Ref: aya-rs#700
Added integration test methods for kretprobe and uretprobe with their appropriate contexts.
tyrone-wu
force-pushed
the
ebpf/split-probe-retprobe-ctx
branch
from
649165f
to
b0d24cd
Compare
|
Lint errors are now resolved. 🐱 |
tyrone-wu
added a commit
to tyrone-wu/aya-template
that referenced
this pull request
Apr 21, 2024
Update kretprobe and uretprobe to use RetProbeContext in response to the changes from aya-rs/aya#912
tyrone-wu
added a commit
to tyrone-wu/aya-template
that referenced
this pull request
Apr 21, 2024
Update kretprobe and uretprobe to use RetProbeContext in response to aya-rs/aya#700 and aya-rs/aya#912
tyrone-wu
added a commit
to tyrone-wu/aya-template
that referenced
this pull request
Apr 21, 2024
Update kretprobe and uretprobe to use RetProbeContext in response to aya-rs/aya#700 and aya-rs/aya#912
alessandrod
approved these changes
Apr 24, 2024
tyrone-wu
added a commit
to tyrone-wu/aya-template
that referenced
this pull request
May 29, 2024
Update kretprobe and uretprobe to use RetProbeContext in response to aya-rs/aya#700 and aya-rs/aya#912
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's my stab at #700. Feel free to let me know if anything needs to be changed or if you're looking for something different. 🙂🙃
Separated
argsaccess tokprobe/uprobeandretaccess tokretprobe/uretprobeby definingProbeContext&RetProbeContextwith onlyargs&retrespectively. Then updated the procedural macros forkprobe/uprobeto only acceptProbeContext, andkretprobe/uretprobeto only acceptRetProbeContext.Fixes: #700