fix(xtask): corrected bpf to ebpf for path to aya-ebpf-bindings in codegen #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when running `cargo +nightly xtask codegen` locally and in the codegen GHA workflow, an error occurs with only "Error: bindgen failed" displayed. This was due to a path using "bpf/..." instead of "ebpf/...". It is now corrected to "ebpf", and bindgen fails should now display a more direct message on why it failed. Fixes: aya-rs#914
✅ Deploy Preview for aya-rs-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Closed
tyrone-wu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when running
cargo +nightly xtask codegenlocally and in the codegen GHA workflow, an error occurs with only "Error: bindgen failed" displayed.This was due to a path using "bpf/..." instead of "ebpf/...". It is now corrected to "ebpf", so the codegen command and GHA workflow shouldn't fail. Additionally, any bindgen fails should now display a more direct message on why it failed.
Fixes: #914