Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Cargo.toml dependencies, made two changes related to update o… #118

Merged
merged 4 commits into from
Jun 27, 2023

Conversation

TawfiqAbubaker
Copy link
Contributor

Necessary changes to make the XDP example from the book work.

Changing :ipv4 to :i

Because of the following aya-log change : aya-rs/aya#599

Adding .unwrap()

The type returned from .map_mut() was changed from Result to Option

Updating Cargo.toml

Api changes were made so the Cargo.toml had to be updated

@netlify
Copy link

netlify bot commented Jun 19, 2023

Deploy Preview for aya-rs ready!

Name Link
🔨 Latest commit 3326756
🔍 Latest deploy log https://app.netlify.com/sites/aya-rs/deploys/649ae9d5ded30b000816ee2e
😎 Deploy Preview https://deploy-preview-118--aya-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@vadorovsky vadorovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TawfiqAbubaker Thanks for working on this! 🙏

There are more examples which need this update, please take a look at the CI error https://github.com/aya-rs/book/actions/runs/5314814694/jobs/9622564529?pr=118

@TawfiqAbubaker
Copy link
Contributor Author

@TawfiqAbubaker Thanks for working on this! 🙏

There are more examples which need this update, please take a look at the CI error https://github.com/aya-rs/book/actions/runs/5314814694/jobs/9622564529?pr=118

I just added another commit, I think it needs you to run the build to see if it's working? I'm not familiar with the build system you have on here. Let me know if it's not working or if I need to add something else

@tamird
Copy link
Member

tamird commented Jun 20, 2023

I believe the current failures are caused by the presence of these Cargo.lock files: https://github.com/search?q=repo%3Aaya-rs%2Fbook%20cargo.lock&type=code

We should probably remove them both

@tamird
Copy link
Member

tamird commented Jun 26, 2023

Looks like some instances of :ipv6 need to be updated as well.

@tamird tamird merged commit 8b40702 into aya-rs:main Jun 27, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants