-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Cargo.toml dependencies, made two changes related to update o… #118
Conversation
✅ Deploy Preview for aya-rs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TawfiqAbubaker Thanks for working on this! 🙏
There are more examples which need this update, please take a look at the CI error https://github.com/aya-rs/book/actions/runs/5314814694/jobs/9622564529?pr=118
I just added another commit, I think it needs you to run the build to see if it's working? I'm not familiar with the build system you have on here. Let me know if it's not working or if I need to add something else |
I believe the current failures are caused by the presence of these We should probably remove them both |
Looks like some instances of |
Necessary changes to make the XDP example from the book work.
Changing
:ipv4
to:i
Because of the following aya-log change : aya-rs/aya#599
Adding
.unwrap()
The type returned from .map_mut() was changed from Result to Option
Updating Cargo.toml
Api changes were made so the Cargo.toml had to be updated