Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: format IP address with {:i} #116

Closed
wants to merge 2 commits into from

Conversation

gingk1212
Copy link

@gingk1212 gingk1212 commented May 29, 2023

{:ipv4} has been replaced with {:i} in aya-rs/aya#599.

This is causing the following compile error.

error: could not parse the format string: unknown display hint: "ipv4"
  --> src/main.rs:68:9
   |
68 |         "SRC IP: {:ipv4}, SRC PORT: {}", source_addr, source_port
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

@netlify
Copy link

netlify bot commented May 29, 2023

Deploy Preview for aya-rs ready!

Name Link
🔨 Latest commit bc4b796
🔍 Latest deploy log https://app.netlify.com/sites/aya-rs/deploys/6474b7fcf0aa5a0008b120ea
😎 Deploy Preview https://deploy-preview-116--aya-rs.netlify.app/book/programs/probes
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

`{:ipv4}` has been replaced with `{:i}` in aya-rs/aya#599.
@gingk1212
Copy link
Author

gingk1212 commented May 30, 2023

The build failure with "kprobetcp" example is due to the presence of Cargo.lock. This Cargo.lock refers to the old main branch of aya-rs/aya.

I think this file should be removed from the repository, can I remove it?

@tamird
Copy link
Member

tamird commented Jun 20, 2023

I think this is being worked on in #118. Apologies this didn't get a review in a timely manner.

@gingk1212 gingk1212 closed this Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants