pref(cmp)!: update keymap for cmp.close
#598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No problem, but this line also needs to be modified if so. Line 108 in 441321b |
This commit changes the keymap for `cmp.close` from `<C-e>` to `<C-w>`.
This way:
* Makes the keymap more intuitive and easier to memorize
(`<C-w>` -> Close the focused window on most platforms)
* Makes `cmp.close` easier to type _(`w` is closer to `<CTRL>` than `e`)_
As this change does not conflict with `<C-w>` in normal mode, no
conflicting keymap was found for the time being.
Jint-lzxy
force-pushed
the
pref/cmp-keymap
branch
from
da64f08
to
109881e
Compare
ayamir
approved these changes
Mar 26, 2023
|
By the way, the default behavior of Also, in nvim-cmp, if |
boomker
pushed a commit
to boomker/uvcode-nvim
that referenced
this pull request
Apr 4, 2023
pref(cmp)!: update keymap for `cmp.close` (cherry picked from commit 4b1684a)
YanTree
pushed a commit
to YanTree/nvim
that referenced
this pull request
Apr 9, 2023
pref(cmp)!: update keymap for `cmp.close`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the keymap for
cmp.closefrom<C-e>to<C-w>.This way:
<C-w>--> Close the focused window on most platforms)cmp.closeeasier to type (wis closer to<CTRL>thane)As this change does not conflict with
<C-w>in normal mode, no conflicting keymap was found for the time being.