Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(mapping): cleanup #657

Merged
merged 1 commit into from
Apr 13, 2023
Merged

chore(mapping): cleanup #657

merged 1 commit into from
Apr 13, 2023

Conversation

Jint-lzxy
Copy link
Collaborator

@Jint-lzxy Jint-lzxy commented Apr 13, 2023 •
edited

This commit made the following changes:

  • Simplify binding commands (e.g., map_cmd(":...<CR>") -> map_cr("...")).
  • Remove <leader><leader>x as this is only available on *nix-like systems.
  • Remove <leader><leader>s b/c some terminals may not refresh their UI in a timely manner 1

Footnotes

  1. The explanation may be a bit complicated, but I will try to keep it concise:
    Since this keymap starts with <Cmd>, although nvim interprets it as :%s/\<(word-under-cursor)\>/(word-under-cursor)/gI and places that on the command line, some terminals may still refuse to refresh their UI (usually, instructions starting with <Cmd> will not be displayed). Since we are, however, in command mode at this point, it would be like typing in the dark - those terminals will only display the previous command after the user performs an operation, which may lead to further issues.
    Sometimes nvim would detect this and throw E5520: <Cmd> mapping must end with <CR> ↩

@CharlesChiuGit
Copy link
Collaborator

  1. The explanation may be a bit complicated, but I will try to keep it concise:
    Since this keymap starts with <Cmd>, although nvim interprets it as :%s/\<(word-under-cursor)\>/(word-under-cursor)/gI and places that on the command line, some terminals may still refuse to refresh their UI (usually, instructions starting with <Cmd> will not be displayed). Since we are, however, in command mode at this point, it would be like typing in the dark - those terminals will only display the previous command after the user performs an operation, which may lead to further issues.
    Sometimes nvim would detect this and throw E5520: mapping must end with ↩

Cool! I didn't know that, thanks for mentioning it!

CharlesChiuGit
CharlesChiuGit approved these changes Apr 13, 2023
View reviewed changes
Copy link
Collaborator

@CharlesChiuGit CharlesChiuGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CharlesChiuGit CharlesChiuGit merged commit fccf351 into 0.9 Apr 13, 2023
2 checks passed
@CharlesChiuGit CharlesChiuGit deleted the chore/mapping(cleanup) branch April 13, 2023 16:07
CharlesChiuGit referenced this pull request in CharlesChiuGit/nvimdots.lua Apr 14, 2023
@CharlesChiuGit
chore(mapping): cleanup
6ba33c6
@TonyWu20 TonyWu20 mentioned this pull request Apr 26, 2023
Merged
Jint-lzxy added a commit that referenced this pull request Apr 30, 2023
@Jint-lzxy @ayamir
@CharlesChiuGit @fecet @AngelontheRoad @Saafo
feat!: support Neovim v0.9 (#697)
08c4561 
* chore(README): bump supported version

* feat(options): support new options shipped with v0.9

* feat(scripts): support v0.9

* feat!: add initial support for lsp semantic tokens (#633)

* feat(utils): use neovim builtin to get highlights (#632)

* fix: remove deprecated options for nvim-tree.

* fix(cmp): support dynamic `kind_text` from cmp source: `treesitter`, fix #624 #634 (#637)

* fix&feat: introduce suda.vim to write file with sudo

* chore(kind_text): cleanup (#648)

* feat(alpha): add custom highlight groups (#650)

* fix: install `psutils` by default for Windows users

* revert: bind `SudaWrite` to `<A-s>`

ref: #641 (comment)

* fix(cmp): nil `vim_item`

* perf(core-mapping): add some useful mapping

* fix(nvim-tree): `hide_root_folder` is deprecated

* perf: load fidget.nvim after `LspAttach`

* minor fix

1. remove `<nop>` at "n|Q"
2. use visual mode instead of visual-line mode for "n|<C-a>"

* perf: align style

* perf(0.9): `stabilize.nvim` had been upstream to `0.9`

* chore(project.nvim): update legacy code

* chore(README): update branch info

* chore(mapping): cleanup (#657)

* fix(icon): update invalid cmp icon (#665)

* chore/lspsaga_move (#667)

* fix: paint word boundary in python (#669)

* fix(bufferline): `show_buffer_default_icon` is now deprecate

* feat(formatting): notify users for files under disabled dirs

* chore(formatting): rephrase messages

* fix(font-encoding): fix invalid characters on windows, fix #639 (#659)

Co-authored-by: 冷酔閑吟 <50296129+Jint-lzxy@users.noreply.github.com>

* pref: unify code style for PowerShell commands

* perf: better guidance to `Discussions` and `Wiki` (#680)

* pref(ISSUE_TEMPLATE): fix typos and format with prettier

* fixup! pref(ISSUE_TEMPLATE): fix typos and format with prettier

* feat(scripts): abort for nvim v0.7 and its antecedent

* feat(settings): allow customization of `transparent_background` (#687)

* fix(bufferline): use defaults for `get_element_icon` (#685)

* feat(auto-session): remember opened buffers (#688)

* revert(keymap): remove redundant mappings.

* fix(catppuccin): properly detect `g:colors_name` (#695)

Ref: upstream breaking change [catppuccin/nvim@7a7a664]

---------

Co-authored-by: ayamir <lgt986452565@gmail.com>
Co-authored-by: Charles Chiu <charleschiu@hey.com>
Co-authored-by: CharlesChiuGit <charleschiu2012@gmail.com>
Co-authored-by: Xie Zejian <xiezej@gmail.com>
Co-authored-by: AngelontheRoad <52699138+AngelontheRoad@users.noreply.github.com>
Co-authored-by: Saafo <46736350+Saafo@users.noreply.github.com>
singlemancombat pushed a commit to singlemancombat/nvim-config that referenced this pull request May 1, 2023
@Jint-lzxy @ayamir
@CharlesChiuGit @fecet @AngelontheRoad @Saafo @singlemancombat
feat!: support Neovim v0.9 (ayamir#697)
2b976ee 
* chore(README): bump supported version

* feat(options): support new options shipped with v0.9

* feat(scripts): support v0.9

* feat!: add initial support for lsp semantic tokens (ayamir#633)

* feat(utils): use neovim builtin to get highlights (ayamir#632)

* fix: remove deprecated options for nvim-tree.

* fix(cmp): support dynamic `kind_text` from cmp source: `treesitter`, fix ayamir#624 ayamir#634 (ayamir#637)

* fix&feat: introduce suda.vim to write file with sudo

* chore(kind_text): cleanup (ayamir#648)

* feat(alpha): add custom highlight groups (ayamir#650)

* fix: install `psutils` by default for Windows users

* revert: bind `SudaWrite` to `<A-s>`

ref: ayamir#641 (comment)

* fix(cmp): nil `vim_item`

* perf(core-mapping): add some useful mapping

* fix(nvim-tree): `hide_root_folder` is deprecated

* perf: load fidget.nvim after `LspAttach`

* minor fix

1. remove `<nop>` at "n|Q"
2. use visual mode instead of visual-line mode for "n|<C-a>"

* perf: align style

* perf(0.9): `stabilize.nvim` had been upstream to `0.9`

* chore(project.nvim): update legacy code

* chore(README): update branch info

* chore(mapping): cleanup (ayamir#657)

* fix(icon): update invalid cmp icon (ayamir#665)

* chore/lspsaga_move (ayamir#667)

* fix: paint word boundary in python (ayamir#669)

* fix(bufferline): `show_buffer_default_icon` is now deprecate

* feat(formatting): notify users for files under disabled dirs

* chore(formatting): rephrase messages

* fix(font-encoding): fix invalid characters on windows, fix ayamir#639 (ayamir#659)

Co-authored-by: 冷酔閑吟 <50296129+Jint-lzxy@users.noreply.github.com>

* pref: unify code style for PowerShell commands

* perf: better guidance to `Discussions` and `Wiki` (ayamir#680)

* pref(ISSUE_TEMPLATE): fix typos and format with prettier

* fixup! pref(ISSUE_TEMPLATE): fix typos and format with prettier

* feat(scripts): abort for nvim v0.7 and its antecedent

* feat(settings): allow customization of `transparent_background` (ayamir#687)

* fix(bufferline): use defaults for `get_element_icon` (ayamir#685)

* feat(auto-session): remember opened buffers (ayamir#688)

* revert(keymap): remove redundant mappings.

* fix(catppuccin): properly detect `g:colors_name` (ayamir#695)

Ref: upstream breaking change [catppuccin/nvim@7a7a664]

---------

Co-authored-by: ayamir <lgt986452565@gmail.com>
Co-authored-by: Charles Chiu <charleschiu@hey.com>
Co-authored-by: CharlesChiuGit <charleschiu2012@gmail.com>
Co-authored-by: Xie Zejian <xiezej@gmail.com>
Co-authored-by: AngelontheRoad <52699138+AngelontheRoad@users.noreply.github.com>
Co-authored-by: Saafo <46736350+Saafo@users.noreply.github.com>
boomker pushed a commit to boomker/uvcode-nvim that referenced this pull request May 2, 2023
@Jint-lzxy @boomker
feat!: support Neovim v0.9 (ayamir#697)
ed8f130 
* chore(README): bump supported version

* feat(options): support new options shipped with v0.9

* feat(scripts): support v0.9

* feat!: add initial support for lsp semantic tokens (ayamir#633)

* feat(utils): use neovim builtin to get highlights (ayamir#632)

* fix: remove deprecated options for nvim-tree.

* fix(cmp): support dynamic `kind_text` from cmp source: `treesitter`, fix ayamir#624 ayamir#634 (ayamir#637)

* fix&feat: introduce suda.vim to write file with sudo

* chore(kind_text): cleanup (ayamir#648)

* feat(alpha): add custom highlight groups (ayamir#650)

* fix: install `psutils` by default for Windows users

* revert: bind `SudaWrite` to `<A-s>`

ref: ayamir#641 (comment)

* fix(cmp): nil `vim_item`

* perf(core-mapping): add some useful mapping

* fix(nvim-tree): `hide_root_folder` is deprecated

* perf: load fidget.nvim after `LspAttach`

* minor fix

1. remove `<nop>` at "n|Q"
2. use visual mode instead of visual-line mode for "n|<C-a>"

* perf: align style

* perf(0.9): `stabilize.nvim` had been upstream to `0.9`

* chore(project.nvim): update legacy code

* chore(README): update branch info

* chore(mapping): cleanup (ayamir#657)

* fix(icon): update invalid cmp icon (ayamir#665)

* chore/lspsaga_move (ayamir#667)

* fix: paint word boundary in python (ayamir#669)

* fix(bufferline): `show_buffer_default_icon` is now deprecate

* feat(formatting): notify users for files under disabled dirs

* chore(formatting): rephrase messages

* fix(font-encoding): fix invalid characters on windows, fix ayamir#639 (ayamir#659)

Co-authored-by: 冷酔閑吟 <50296129+Jint-lzxy@users.noreply.github.com>

* pref: unify code style for PowerShell commands

* perf: better guidance to `Discussions` and `Wiki` (ayamir#680)

* pref(ISSUE_TEMPLATE): fix typos and format with prettier

* fixup! pref(ISSUE_TEMPLATE): fix typos and format with prettier

* feat(scripts): abort for nvim v0.7 and its antecedent

* feat(settings): allow customization of `transparent_background` (ayamir#687)

* fix(bufferline): use defaults for `get_element_icon` (ayamir#685)

* feat(auto-session): remember opened buffers (ayamir#688)

* revert(keymap): remove redundant mappings.

* fix(catppuccin): properly detect `g:colors_name` (ayamir#695)

Ref: upstream breaking change [catppuccin/nvim@7a7a664]

---------

Co-authored-by: ayamir <lgt986452565@gmail.com>
Co-authored-by: Charles Chiu <charleschiu@hey.com>
Co-authored-by: CharlesChiuGit <charleschiu2012@gmail.com>
Co-authored-by: Xie Zejian <xiezej@gmail.com>
Co-authored-by: AngelontheRoad <52699138+AngelontheRoad@users.noreply.github.com>
Co-authored-by: Saafo <46736350+Saafo@users.noreply.github.com>
(cherry picked from commit 08c4561)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlesChiuGit CharlesChiuGit CharlesChiuGit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jint-lzxy @CharlesChiuGit