fix: write file with sudo #641

ayamir · 2023-04-10T15:40:41Z

No description provided.

ayamir · 2023-04-10T15:42:02Z

Need one to test it, because I set NOPASSWD for me so I won't see the prompt for sudo password.

Jint-lzxy · 2023-04-11T12:11:14Z

7dd7f0f reverted the keymap from <A-s> to <C-S-s>. @ayamir is this intentional?

Jint-lzxy

LGTM 🍓

ayamir · 2023-04-11T13:04:01Z

I just found that all of my terminals perhaps can't handle <C-S-s> correctly. It is interpreted to <C-s> and Shift so the result is below.

But set it to <A-s> works.

Jint-lzxy · 2023-04-11T13:49:00Z

Looks like some terminal emulators require users to manually define those special ANSI escape sequences:
kitty.conf:

map ctrl+shift+s send_text all \x1b[83;5u

alacritty.yml:

- { key: S, mods: Control|Shift, chars: "\x1b[83;5u" }

But AFAIK, many terminals already have this feature builtin.

Jint-lzxy · 2023-04-11T13:52:59Z

Looks like Windows doesn't have sudo builtin. psutils will be added to the install script.

CharlesChiuGit · 2023-04-11T13:55:33Z

Looks like Windows doesn't have sudo builtin. psutils will be added to the install script.

there's a "sudo" package in scoop, not sure if choco has sth similar or not.

CharlesChiuGit · 2023-04-11T13:56:52Z

Looks like some terminal emulators require users to manually define those special ANSI escape sequences:

kitty.conf:
map ctrl+shift+s send_text all \x1b[83;5u
alacritty.yml:
- { key: S, mods: Control|Shift, chars: "\x1b[83;5u" }
But AFAIK, many terminals already have this feature builtin.

this is very likely to cause a lot of upcoming issues lol

Jint-lzxy · 2023-04-11T13:57:13Z

@CharlesChiuGit psutils should do the trick 😃

Jint-lzxy · 2023-04-11T14:01:04Z

this is very likely to cause a lot of upcoming issues lol

🥲 Better mention this issue in wiki:FAQ

ayamir · 2023-04-11T14:09:02Z

this is very likely to cause a lot of upcoming issues lol

Yes, <C-S-s> won't work for all of my terminals: kitty, wezterm and alacritty.

ref: #641 (comment)

Jint-lzxy · 2023-04-11T14:17:46Z

Reverted to avoid further issues 👍

* chore(README): bump supported version * feat(options): support new options shipped with v0.9 * feat(scripts): support v0.9 * feat!: add initial support for lsp semantic tokens (#633) * feat(utils): use neovim builtin to get highlights (#632) * fix: remove deprecated options for nvim-tree. * fix(cmp): support dynamic `kind_text` from cmp source: `treesitter`, fix #624 #634 (#637) * fix&feat: introduce suda.vim to write file with sudo * chore(kind_text): cleanup (#648) * feat(alpha): add custom highlight groups (#650) * fix: install `psutils` by default for Windows users * revert: bind `SudaWrite` to `<A-s>` ref: #641 (comment) * fix(cmp): nil `vim_item` * perf(core-mapping): add some useful mapping * fix(nvim-tree): `hide_root_folder` is deprecated * perf: load fidget.nvim after `LspAttach` * minor fix 1. remove `<nop>` at "n|Q" 2. use visual mode instead of visual-line mode for "n|<C-a>" * perf: align style * perf(0.9): `stabilize.nvim` had been upstream to `0.9` * chore(project.nvim): update legacy code * chore(README): update branch info * chore(mapping): cleanup (#657) * fix(icon): update invalid cmp icon (#665) * chore/lspsaga_move (#667) * fix: paint word boundary in python (#669) * fix(bufferline): `show_buffer_default_icon` is now deprecate * feat(formatting): notify users for files under disabled dirs * chore(formatting): rephrase messages * fix(font-encoding): fix invalid characters on windows, fix #639 (#659) Co-authored-by: 冷酔閑吟 <50296129+Jint-lzxy@users.noreply.github.com> * pref: unify code style for PowerShell commands * perf: better guidance to `Discussions` and `Wiki` (#680) * pref(ISSUE_TEMPLATE): fix typos and format with prettier * fixup! pref(ISSUE_TEMPLATE): fix typos and format with prettier * feat(scripts): abort for nvim v0.7 and its antecedent * feat(settings): allow customization of `transparent_background` (#687) * fix(bufferline): use defaults for `get_element_icon` (#685) * feat(auto-session): remember opened buffers (#688) * revert(keymap): remove redundant mappings. * fix(catppuccin): properly detect `g:colors_name` (#695) Ref: upstream breaking change [catppuccin/nvim@7a7a664] --------- Co-authored-by: ayamir <lgt986452565@gmail.com> Co-authored-by: Charles Chiu <charleschiu@hey.com> Co-authored-by: CharlesChiuGit <charleschiu2012@gmail.com> Co-authored-by: Xie Zejian <xiezej@gmail.com> Co-authored-by: AngelontheRoad <52699138+AngelontheRoad@users.noreply.github.com> Co-authored-by: Saafo <46736350+Saafo@users.noreply.github.com>

* chore(README): bump supported version * feat(options): support new options shipped with v0.9 * feat(scripts): support v0.9 * feat!: add initial support for lsp semantic tokens (ayamir#633) * feat(utils): use neovim builtin to get highlights (ayamir#632) * fix: remove deprecated options for nvim-tree. * fix(cmp): support dynamic `kind_text` from cmp source: `treesitter`, fix ayamir#624 ayamir#634 (ayamir#637) * fix&feat: introduce suda.vim to write file with sudo * chore(kind_text): cleanup (ayamir#648) * feat(alpha): add custom highlight groups (ayamir#650) * fix: install `psutils` by default for Windows users * revert: bind `SudaWrite` to `<A-s>` ref: ayamir#641 (comment) * fix(cmp): nil `vim_item` * perf(core-mapping): add some useful mapping * fix(nvim-tree): `hide_root_folder` is deprecated * perf: load fidget.nvim after `LspAttach` * minor fix 1. remove `<nop>` at "n|Q" 2. use visual mode instead of visual-line mode for "n|<C-a>" * perf: align style * perf(0.9): `stabilize.nvim` had been upstream to `0.9` * chore(project.nvim): update legacy code * chore(README): update branch info * chore(mapping): cleanup (ayamir#657) * fix(icon): update invalid cmp icon (ayamir#665) * chore/lspsaga_move (ayamir#667) * fix: paint word boundary in python (ayamir#669) * fix(bufferline): `show_buffer_default_icon` is now deprecate * feat(formatting): notify users for files under disabled dirs * chore(formatting): rephrase messages * fix(font-encoding): fix invalid characters on windows, fix ayamir#639 (ayamir#659) Co-authored-by: 冷酔閑吟 <50296129+Jint-lzxy@users.noreply.github.com> * pref: unify code style for PowerShell commands * perf: better guidance to `Discussions` and `Wiki` (ayamir#680) * pref(ISSUE_TEMPLATE): fix typos and format with prettier * fixup! pref(ISSUE_TEMPLATE): fix typos and format with prettier * feat(scripts): abort for nvim v0.7 and its antecedent * feat(settings): allow customization of `transparent_background` (ayamir#687) * fix(bufferline): use defaults for `get_element_icon` (ayamir#685) * feat(auto-session): remember opened buffers (ayamir#688) * revert(keymap): remove redundant mappings. * fix(catppuccin): properly detect `g:colors_name` (ayamir#695) Ref: upstream breaking change [catppuccin/nvim@7a7a664] --------- Co-authored-by: ayamir <lgt986452565@gmail.com> Co-authored-by: Charles Chiu <charleschiu@hey.com> Co-authored-by: CharlesChiuGit <charleschiu2012@gmail.com> Co-authored-by: Xie Zejian <xiezej@gmail.com> Co-authored-by: AngelontheRoad <52699138+AngelontheRoad@users.noreply.github.com> Co-authored-by: Saafo <46736350+Saafo@users.noreply.github.com>

* chore(README): bump supported version * feat(options): support new options shipped with v0.9 * feat(scripts): support v0.9 * feat!: add initial support for lsp semantic tokens (ayamir#633) * feat(utils): use neovim builtin to get highlights (ayamir#632) * fix: remove deprecated options for nvim-tree. * fix(cmp): support dynamic `kind_text` from cmp source: `treesitter`, fix ayamir#624 ayamir#634 (ayamir#637) * fix&feat: introduce suda.vim to write file with sudo * chore(kind_text): cleanup (ayamir#648) * feat(alpha): add custom highlight groups (ayamir#650) * fix: install `psutils` by default for Windows users * revert: bind `SudaWrite` to `<A-s>` ref: ayamir#641 (comment) * fix(cmp): nil `vim_item` * perf(core-mapping): add some useful mapping * fix(nvim-tree): `hide_root_folder` is deprecated * perf: load fidget.nvim after `LspAttach` * minor fix 1. remove `<nop>` at "n|Q" 2. use visual mode instead of visual-line mode for "n|<C-a>" * perf: align style * perf(0.9): `stabilize.nvim` had been upstream to `0.9` * chore(project.nvim): update legacy code * chore(README): update branch info * chore(mapping): cleanup (ayamir#657) * fix(icon): update invalid cmp icon (ayamir#665) * chore/lspsaga_move (ayamir#667) * fix: paint word boundary in python (ayamir#669) * fix(bufferline): `show_buffer_default_icon` is now deprecate * feat(formatting): notify users for files under disabled dirs * chore(formatting): rephrase messages * fix(font-encoding): fix invalid characters on windows, fix ayamir#639 (ayamir#659) Co-authored-by: 冷酔閑吟 <50296129+Jint-lzxy@users.noreply.github.com> * pref: unify code style for PowerShell commands * perf: better guidance to `Discussions` and `Wiki` (ayamir#680) * pref(ISSUE_TEMPLATE): fix typos and format with prettier * fixup! pref(ISSUE_TEMPLATE): fix typos and format with prettier * feat(scripts): abort for nvim v0.7 and its antecedent * feat(settings): allow customization of `transparent_background` (ayamir#687) * fix(bufferline): use defaults for `get_element_icon` (ayamir#685) * feat(auto-session): remember opened buffers (ayamir#688) * revert(keymap): remove redundant mappings. * fix(catppuccin): properly detect `g:colors_name` (ayamir#695) Ref: upstream breaking change [catppuccin/nvim@7a7a664] --------- Co-authored-by: ayamir <lgt986452565@gmail.com> Co-authored-by: Charles Chiu <charleschiu@hey.com> Co-authored-by: CharlesChiuGit <charleschiu2012@gmail.com> Co-authored-by: Xie Zejian <xiezej@gmail.com> Co-authored-by: AngelontheRoad <52699138+AngelontheRoad@users.noreply.github.com> Co-authored-by: Saafo <46736350+Saafo@users.noreply.github.com> (cherry picked from commit 08c4561)

ayamir changed the title ~~Fix/sudo~~ fix: write file with sudo Apr 10, 2023

ayamir linked an issue Apr 10, 2023 that may be closed by this pull request

Cannot use sudo write #617

Closed

ayamir changed the base branch from main to 0.9 April 10, 2023 15:51

fix&feat: introduce suda.vim to write file with sudo

7dd7f0f

Jint-lzxy force-pushed the fix/sudo branch from 39a776a to 7dd7f0f Compare April 11, 2023 12:08

Jint-lzxy approved these changes Apr 11, 2023

View reviewed changes

fix: install psutils by default for Windows users

a9752b7

Jint-lzxy force-pushed the fix/sudo branch from 2010ffb to a9752b7 Compare April 11, 2023 13:58

revert: bind SudaWrite to <A-s>

70dedba

ref: #641 (comment)

ayamir merged commit b02c8bc into 0.9 Apr 11, 2023

ayamir deleted the fix/sudo branch April 11, 2023 15:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: write file with sudo #641

fix: write file with sudo #641

ayamir commented Apr 10, 2023

ayamir commented Apr 10, 2023 •

edited

Loading

Jint-lzxy commented Apr 11, 2023 •

edited

Loading

Jint-lzxy left a comment

ayamir commented Apr 11, 2023 •

edited

Loading

Jint-lzxy commented Apr 11, 2023

Jint-lzxy commented Apr 11, 2023

CharlesChiuGit commented Apr 11, 2023 •

edited

Loading

CharlesChiuGit commented Apr 11, 2023

Jint-lzxy commented Apr 11, 2023

Jint-lzxy commented Apr 11, 2023

ayamir commented Apr 11, 2023

Jint-lzxy commented Apr 11, 2023

fix: write file with sudo #641

fix: write file with sudo #641

Conversation

ayamir commented Apr 10, 2023

ayamir commented Apr 10, 2023 • edited Loading

Jint-lzxy commented Apr 11, 2023 • edited Loading

Jint-lzxy left a comment

Choose a reason for hiding this comment

ayamir commented Apr 11, 2023 • edited Loading

Jint-lzxy commented Apr 11, 2023

Jint-lzxy commented Apr 11, 2023

CharlesChiuGit commented Apr 11, 2023 • edited Loading

CharlesChiuGit commented Apr 11, 2023

Jint-lzxy commented Apr 11, 2023

Jint-lzxy commented Apr 11, 2023

ayamir commented Apr 11, 2023

Jint-lzxy commented Apr 11, 2023

ayamir commented Apr 10, 2023 •

edited

Loading

Jint-lzxy commented Apr 11, 2023 •

edited

Loading

ayamir commented Apr 11, 2023 •

edited

Loading

CharlesChiuGit commented Apr 11, 2023 •

edited

Loading