image: fix TestMono test #6
Conversation
I wanted to fix the TODO (whether the decoded image was actually valid)
but found that it wasn't:
- The size wasn't correct. The TinyGo logo was actually 304x255 in
size, not 299x255 (it looks like it was created with a tool that
assumes every row starts at a byte aligned line, which image.Mono
doesn't).
- There seems to be a problem when the image is decoded as a
pixel.Monochrome, but I haven't yet figured out why.
aykevl
force-pushed
the
fix-image-mono-test
branch
from
dce2ce8
to
0d8f650
Compare
|
How come the test image has that dark vertical line on the rightmost margin? |
|
Because that's what the raw image contains. See my previous comment:
So basically the raw image does have the dark vertical line on the right, but depending on how it is being interpreted this may or may not be visible. The way that |
|
We probably should replace that image with one that is "correct", but that is separate issue from this test. |
|
Yes, indeed. |
|
It would be fine to correct that in this PR, I think. |
I wanted to fix the TODO (whether the decoded image was actually valid) but found that it wasn't:
@deadprogram can you take a look at this? Does this make sense?