Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Image support #95

Closed
jrvgr opened this issue Nov 5, 2021 · 13 comments · Fixed by #274
Closed

Feature request: Image support #95

jrvgr opened this issue Nov 5, 2021 · 13 comments · Fixed by #274
Labels
feat New feature or request

Comments

@jrvgr
Copy link

jrvgr commented Nov 5, 2021

hi i would like to see image embeds being shown in the client itself instead of needing a external viewer for it

@ghost ghost added the feat New feature or request label Nov 5, 2021
@ghost ghost changed the title image support in Discordo Feature request: Image support Nov 17, 2021
@ghost ghost added the pending label Jan 19, 2022
@DremOSDeveloperTeam
Copy link

Looking into this.

@ghost ghost removed the pending label Feb 25, 2022
@TheScreechingBagel
Copy link

TheScreechingBagel commented Mar 1, 2022

w3m ,the terminal browser does this:
https://github.com/tokuhirom/w3m/blob/master/w3mimg/x11/x11_w3mimg.c
edit: this is x11-only though...
and depends on xterm

@DremOSDeveloperTeam
Copy link

The implementation I attempted used SIXEL instead. Most terminals still don't support this standard, but actually printing the SIXEL escape sequences to the correct location and having it scroll does not seem easy, at least to me. The code that actually downloads and translates images to SIXEL escape sequences is done, and avalible in the "images" branch on my fork (after I push what I've pulled together tonight).

@TheScreechingBagel
Copy link

Here is a ranger issue #mentioning this:ranger/ranger#1476
It mentions imv

@KodiCraft
Copy link
Contributor

A Kitty based implementation with something like icat would be neat, but that would probably have to be implemented in a completely different way

@emilydaemon
Copy link

Being able to use chafa as the image backend would be nice.

@carterprince
Copy link
Contributor

If this is implemented, it should definitely use ueberzug in my opinion. It would probably be complicated, though. For now, as a workaround, there should be a hotkey to open the link to an image in your preferred image viewer.

@diamondburned
Copy link

6cord had sixel support then why not discordo?

6cord actually did not have SIXEL support. As @DremOSDeveloperTeam pointed out, supporting SIXEL in something like tview is tedious work.

That said, tcell-sixel could be of use for that. foot also supports SIXEL.

@peepo5
Copy link

peepo5 commented Aug 24, 2022

@diamondburned it looks pretty good. Videos could also be implemented (but it would require some work haha)

@Cons-Cat
Copy link

Cons-Cat commented Sep 8, 2022

Animated images that can move in a terminal efficiently is precisely what the Kitty graphics protocol was invented to do.

@Cons-Cat
Copy link

Cons-Cat commented Sep 9, 2022

Animated images that can move in a terminal efficiently is precisely what the Kitty graphics protocol was invented to do.

Fuck you why are you obsessed with kitty shitty ?

Do you honestly think that Sixel is as good as Kitty's protocol?

@diamondburned
Copy link

diamondburned commented Sep 9, 2022

Who told you? Then what is this? https://github.com/diamondburned/real6cord

It's garbage that does not work 🙃

Try asking the developer and see what they have to say about it.

P/S: I'm not going to babysit this issue (it's not my issue), but I would much rather we maintain a constructive tone rather than yelling "dose of copium" at someone else. I don't think that's at all productive or helpful to anyone.

@ghost ghost locked as too heated and limited conversation to collaborators Sep 9, 2022
@ayn2op
Copy link
Owner

ayn2op commented Jan 2, 2023

Repository owner deleted a comment Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feat New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

11 participants