Expunge bloop and add an sbt welcome message #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jisantuc
changed the title
rbreslow
approved these changes
Jan 26, 2021
There was a problem hiding this comment.
I was able to follow your testing instructions. Also, I think these are all good improvements. 👍
One interesting thing is that migrations and the application server seem to be using the error logger:
[info] running (fork) com.azavea.quickstart.api.Server migrate
[error] [ioapp-compute-4] INFO org.flywaydb.core.internal.license.VersionPrinter - Flyway Community Edition 6.5.0 by Redgate
[error] [ioapp-compute-4] INFO org.flywaydb.core.internal.database.DatabaseFactory - Database: jdbc:postgresql://localhost:5432/quickstart (PostgreSQL 12.4)
[error] [ioapp-compute-4] INFO org.flywaydb.core.internal.command.DbValidate - Successfully validated 1 migration (execution time 00:00.020s)
[error] [ioapp-compute-4] INFO org.flywaydb.core.internal.schemahistory.JdbcTableSchemaHistory - Creating Schema History table "public"."flyway_schema_history" ...
[error] [ioapp-compute-4] INFO org.flywaydb.core.internal.command.DbMigrate - Current version of schema "public": << Empty Schema >>
[error] [ioapp-compute-4] INFO org.flywaydb.core.internal.command.DbMigrate - Migrating schema "public" to version 1 - Add PostGIS and Users
[error] [ioapp-compute-4] INFO org.flywaydb.core.internal.command.DbMigrate - Successfully applied 1 migration to schema "public" (execution time 00:01.286s)
[success] Total time: 27 s, completed Jan 26, 2021 4:58:09 PM
. . .
[error] [ioapp-compute-4] INFO org.http4s.blaze.channel.nio1.NIO1SocketServerGroup - Service bound to address /0:0:0:0:0:0:0:0:8080
[error] [ioapp-compute-4] INFO org.http4s.server.blaze.BlazeServerBuilder -
[error] _ _ _ _ _
[error] | |_| |_| |_ _ __| | | ___
[error] | ' \ _| _| '_ \_ _(_-<
[error] |_||_\__|\__| .__/ |_|/__/
[error] |_|
[error] [ioapp-compute-4] INFO org.http4s.server.blaze.BlazeServerBuilder - http4s v0.21.5 on blaze v0.14.12 started at http://[::]:8080/
[error] [blaze-selector-1] INFO org.http4s.blaze.channel.nio1.NIO1SocketServerGroup - Accepted connection from /0:0:0:0:0:0:0:1:50892Also, when you run server, the azavea.g8 help message is displayed. I'd expect that to only be displayed when invoking sbt without a valid command. Just a nit.
|
I think I can come up with a trick to suppress the welcome message except when starting the sbt shell. I don't know what to do about the logger thing just yet... it's ringing some bells, but they're faint. I'll take a stab at it though. |
This commit: - removes the onload hook to switch to application - adds the command to switch to application to the root welcome message - moves the big welcome message with the noisy logo to the application subproject
|
I wasn't able to fully kill the welcome message in the root project, but it's a lot less obnoxious now as of 75d57da |
|
The error-level logging is also an issue on It's not clear to me where this log level is coming from. I'm going to open a follow-up issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Consistent feedback in the state of scala survey (other than "why is this survey so long") was that sbt is hard. This PR adds
the sbt-welcome-message plugin so that on project startup users will see a nice list of available commands. This should at
least remove friction for the most commonly executed tasks.
This PR also removes the bloop invocations from setup and CI (well not CI yet but soon).
Notes
I didn't include the
sbthelper script here after all since escaping the$s was causing a lot of problems.Testing
sbt new "file://$(pwd)/azavea.g8"quickstart./sbt(you can borrow it from Franklin or just usesbtif it's on your path) and check out the beautiful welcome message full of useful things you can do./scripts/update, then./scripts/server. your server should come up successfully.Closes #9