Don't call non-existant property on Exception class

[fungjj92]

Overview

Changes to the python base Exception class in PEP 352 included a deprecation (2.6 -> 2.7) and subsequent removal of the message property (-> Py3). This is a rather obscure change that didn't get caught in the prior python 3 upgrade of this library. I ran into this issue while fixing broken OTM tests in the process of upgrading OTM from py2 to 3, namely OTM-core. The error was AttributeError: 'HttpBadRequestException' object has no attribute 'message'

Testing

I tested these changes in OTM-core and the tests that were previously failing passed.

[jwalgran]

Looking at this now.

[jwalgran]

Looks good. I wrote a test to verify this in isolation outside of OTM. Consider adding it to the suite.
(bad_response_view was unused)

diff --git a/test_app/django_tinsel_tests/tests.py b/test_app/django_tinsel_tests/tests.py
index 7953ee6..33af37f 100644
--- a/test_app/django_tinsel_tests/tests.py
+++ b/test_app/django_tinsel_tests/tests.py
@@ -15,6 +15,7 @@ from .context import django_tinsel  # NOQA
 from django_tinsel.decorators import (route, log, render_template,
                                       json_api_call, string_to_response,
                                       username_matches_request_user)
+from django_tinsel.exceptions import HttpBadRequestException
 from django_tinsel.utils import decorate
 
 
@@ -31,8 +32,8 @@ def redirect_view(request):
     return HttpResponseRedirect("http://lmgtfy.com")
 
 
-def bad_response_view(request):
-    return HttpResponseBadRequest("Goodbye World")
+def raise_bad_request_view(request):
+    raise HttpBadRequestException("raised HttpBadRequestException")
 
 
 @username_matches_request_user
@@ -150,6 +151,11 @@ class StringToResponseTests(BaseTestCase):
         self.assertEqual("text/csv", resp['Content-Type'])
         self.assertEqual('11', resp['Content-Length'])
 
+    def test_bad_request_exception(self):
+        failing_view = string_to_response("text/plain")(raise_bad_request_view)
+        resp = failing_view(self.get_req)
+        self.assertEqual(b'raised HttpBadRequestException', resp.content)
+
 
 class UsernameMatchesRequestUserTests(BaseTestCase):
     def setUp(self):

[fungjj92]

Thanks for the test! I didn't notice this project had tests set up.