Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling pass of app #26

Merged
merged 2 commits into from
Aug 13, 2018
Merged

Styling pass of app #26

merged 2 commits into from
Aug 13, 2018

Conversation

alexelash
Copy link
Contributor

Overview

This is a styling pass of the currently available features of the app. As there isn't a ton of time in the contract, these will still not look exactly like the flat designs in abstract.

Demo

screen shot 2018-08-10 at 1 02 03 pm

screen shot 2018-08-10 at 1 02 07 pm

screen shot 2018-08-10 at 1 02 14 pm

screen shot 2018-08-10 at 1 02 24 pm

screen shot 2018-08-10 at 1 06 46 pm

Notes

  • I added an images/ directory, where some custom icons live (we are pulling in FontAwesome rather than using Fontello on this project) as well as client logos.
  • We still need to add the "Sponsored by IDB" message. There is a corresponding image in the images/ folder.
  • We still need (?) to add the "Something look wrong? Update..." message to the bottom-left of the map. This is not dynamic in anyway and is always visible.
  • It would be nice to try and style the react-select inputs' selected and hover states. @kellyi and I were discussing how this could be done, but it might require some React-writing rather than SCSS.
  • The extract button should be disabled until the "required" fields in the sidebar are filled in.

Testing Instructions

  • git pull
  • In the browser, put a .-disabled class on the .-extract button to see the disabled styles
  • Try running a search in the Geocoder. Toggle to Coordinates to see the Lat/Long design.
  • Click the "i" icon in the sidebar header to see style revisions.
  • Click one of the site boundary buttons and try drawing on the map to see the various states of the buttons.

@kellyi
Copy link
Contributor

kellyi commented Aug 13, 2018

Looks great! I pushed a commit to disabled the extract button contextually and also to make the focused select dropdown option's background $lightyellow to match the geocoder's.

Copy link
Contributor

@kellyi kellyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Will make new issues for the logo & OSM link.

@kellyi kellyi assigned alexelash and unassigned kellyi Aug 13, 2018
@alexelash alexelash merged commit 90a3b1b into develop Aug 13, 2018
@alexelash alexelash deleted the feature/al/styling-pass branch August 13, 2018 15:35
@kellyi kellyi mentioned this pull request Aug 13, 2018
@kellyi kellyi self-assigned this Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants