adds additional keys and values #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, financial, and public transport
mmcfarland
approved these changes
Mar 12, 2019
There was a problem hiding this comment.
This looks good to me. In Georgetown, the number of features returned increased significantly. Seems like a good thing, but we may now need to pay attention to area size and rendering that many features on the map, or tripping API limits in Overpass. My sense is to get this out there for testing and deal with fallout from how they actually use it.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds additional keys and values for the following labels:
Changes were made by comparing queries from the tool with data pulled using JOSM and querying individual features in OSM.
Notes
Some labels will result in queries that select the same feature. For example, selecting
Buildingsand thenAmenitiesmay result in the same feature being selected in both queries because it has tags that apply to both. I don't think there is any way around this, especially because thebuilding=yestag is so broad but required for most building polygons.