Force users to reset password on first login #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
commented
Sep 29, 2022
Comment on lines
-46
to
+47
| RESET: 'api/auth/password/reset/confirm/', | ||
| CONFIRM: 'api/auth/password/reset/confirm/', | ||
| RESET: 'confirm_password_reset/reset/', |
There was a problem hiding this comment.
This was starting to get confusing, so this is my new proposal (see updates to axios calls, below).
Comment on lines
+28
to
+30
| context = { | ||
| 'uid': urlsafe_base64_encode(force_bytes(user.pk)), | ||
| 'token': default_token_generator.make_token(user), |
There was a problem hiding this comment.
jacobtylerwalls
force-pushed
the
jw/admin-generated-pw
branch
from
d13f9c5
to
e916dd1
Compare
rachelekm
approved these changes
Sep 30, 2022
jacobtylerwalls
force-pushed
the
jw/admin-generated-pw
branch
from
e916dd1
to
456c14d
Compare
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Force users to reset their password on first login.
Closes #67
Notes
has_admin_generated_passwordto False, so that flow will not force the user to reset their password. If that is desired, that could be a follow-up card.Testing Instructions
scripts/resetdbscripts/serverChecklist
fixup!commits have been squashedCHANGELOG.mdupdated with summary of features or fixes, following Keep a Changelog guidelinesREADME.mdupdated if necessary to reflect the changes