Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crosshairs on Treecorder block selection misaligned #1866

Closed
dboyer opened this issue May 4, 2016 · 5 comments
Closed

Crosshairs on Treecorder block selection misaligned #1866

dboyer opened this issue May 4, 2016 · 5 comments
Assignees
Labels

Comments

@dboyer
Copy link

dboyer commented May 4, 2016

On smaller screens, the crosshairs fall behind the help text or are not centered on the map.

@dboyer
Copy link
Author

dboyer commented May 4, 2016

img_0472

@jwalgran
Copy link
Member

jwalgran commented May 5, 2016

I think this is the source of the regression

e77f3ab#diff-2d673cf24021cc99e1c1a29e34d437deR25

If I revert the media query back to what it was

@media (max-width: $screen-sm) {
    bottom: 20rem;
}

The crosshairs start working again because the map div shrinks properly.

@jwalgran jwalgran added the bug label May 5, 2016
@RickMohr RickMohr added the queue label May 5, 2016
@designmatty
Copy link
Contributor

@jwalgran you're totally right. Adding that 20rem back in will fix this.

@maurizi
Copy link
Contributor

maurizi commented May 5, 2016

@designmatty I believe adding it back in will break something else on the treecorder screen. I can stop by and show you.

@designmatty
Copy link
Contributor

@maurizi I'll work on it tomorrow so we can chat about it then

@maurizi maurizi added in review and removed queue labels May 6, 2016
designmatty added a commit that referenced this issue May 6, 2016
fix #1866. map no longer cut off or showing through on the survey for…
@maurizi maurizi removed the in review label May 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants