Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data dictionary and draft models #20

Merged
merged 3 commits into from
Oct 21, 2014
Merged

Add data dictionary and draft models #20

merged 3 commits into from
Oct 21, 2014

Conversation

jwalgran
Copy link
Member

No description provided.

@maurizi
Copy link
Contributor

maurizi commented Oct 14, 2014

Why does every model have created_at and updated_at? Do we want to pull those fields out into a separate abstract Model?

@steventlamb
Copy link
Contributor

I prefer created and updated.

@jwalgran
Copy link
Member Author

Django maintains will maintain these dates for us, so I thought we might as well add them. @steventlamb If created and updated are more idiomatic, I agree we should change them (_at is the Rails convention)

@jwalgran
Copy link
Member Author

Sorry I trashed some of our conversation with a rebase.

Rick had asked about is_available on the Blockfaces table. There is a requirement that Parks be able to open a blockface for mapping, even if it has been previously surveyed. We could say "if all the Surveys for a Blockface have is_flagged set to True (which means that we do not fully trust them) then allow the Blockface to be mapped." This is more normalized, but complicates the tiler query. I am not sure which way we should go.

@jwalgran
Copy link
Member Author

@RickMohr Parks and TreeKit have not defined the final list of metadata we will be collecting for each tree. I took the fields that are included from the CartoDB table that TreeKit has used in the past, so they are a reasonably good starting point.

@jwalgran
Copy link
Member Author

@RickMohr The spec indicates that attendance at an event counts as "training completed"

@RickMohr
Copy link
Contributor

I prefer created_at and updated_at. created and updated sound like Booleans.

@kdeloach
Copy link
Contributor

Consider using date fields in place of boolean fields. They provide way more data/context and may come in handy later.

@jwalgran
Copy link
Member Author

I like _at too.

@RickMohr
Copy link
Contributor

@kdeloach, they are date fields.

@jwalgran
Copy link
Member Author

@RickMohr Territory (the new name for Turf) is more or less permanent. It represents the collection of blockfaces assigned to a Group. We do not need to worry about expiration and cancelation.

@steventlamb
Copy link
Contributor

I could have sworn that created and updated were more idiomatic, but I can't find evidence. In fact, I found some cases of created_at as well as created. Github search kinda sucks for this type of thing. They can't seem to find "created = ", and give me all instances of %created%

@kdeloach
Copy link
Contributor

I meant other Boolean fields is_flagged, is_banned, etc.

@jwalgran
Copy link
Member Author

@kdeloach The plan, right now, is to bing over Auditable from OpenTreeMap so that the "who" and "when" of flagging and banning is captured, if we care to dig it up, while using a real boolean for the property

Describes all the table that will be used by the application.
The purpose of this file is to review the model attribe decisions being
made before incorporating the models into the appropriate Django
applications.
jwalgran added a commit that referenced this pull request Oct 21, 2014
@jwalgran jwalgran merged commit 105046f into azavea:develop Oct 21, 2014
@jwalgran jwalgran deleted the topic/add-data-dictionary branch October 21, 2014 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants