Remove usage of the ESRI WGS geocoder find endpoint
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESRI deprecated the `find` endpoint. On or around June 28th 2017 several WGS related unit test started failing. This commit removes the usage of `find` and passes all ESRI WGS geocoder requests to the `findAddressCandidates` endpoint. The capitalization of a few attributes returned from the `findAddressCandidates` endpoint differed from what the code expected and required changes.
|
You ran these tests with all of the API keys present or just the Esri ones? |
|
@hectcastro I believe the ESRI geocoding services do not require an API key. |
|
When running the tests I exported the same API keys that the CI job on jenkins01 does. |
hectcastro
pushed a commit
that referenced
this pull request
Jun 29, 2017
Add Travis CI support for testing the library's supported APIs with Python 2.7. In addition, add support for automatic package publishing to PyPI. Lastly, skip failing MapQuest test that were failing prior to the bug addressed in #30.
KlaasH
approved these changes
Jun 29, 2017
hectcastro
pushed a commit
that referenced
this pull request
Jun 29, 2017
Add Travis CI support for testing the library's supported APIs with Python 2.7. In addition, add support for automatic package publishing to PyPI. Lastly, skip failing MapQuest test that were failing prior to the bug addressed in #30.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESRI deprecated the
findendpoint. On or around June 28th 2017 several WGS related unit test started failing. This commit removes the usage offindand passes all ESRI WGS geocoder requests to thefindAddressCandidatesendpoint. The capitalization of a few attributes returned from thefindAddressCandidatesendpoint differed from what the code expected and required changes.Testing
Before the ESRI WGS test began failing, these three tests were already failling:
Only these three tests should fail when running the unit tests.
Connects to https://github.com/OpenTreeMap/otm-cloud/issues/384