Remove usage of the ESRI WGS geocoder find
endpoint
#30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESRI deprecated the
find
endpoint. On or around June 28th 2017 several WGS related unit test started failing. This commit removes the usage offind
and passes all ESRI WGS geocoder requests to thefindAddressCandidates
endpoint. The capitalization of a few attributes returned from thefindAddressCandidates
endpoint differed from what the code expected and required changes.Testing
Before the ESRI WGS test began failing, these three tests were already failling:
Only these three tests should fail when running the unit tests.
Connects to https://github.com/OpenTreeMap/otm-cloud/issues/384