Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make image name handling in docker/ecr_publish consistent with docker/build #1559

Merged
merged 3 commits into from Nov 21, 2022

Conversation

AdeelH
Copy link
Collaborator

@AdeelH AdeelH commented Nov 21, 2022

Overview

This PR fixes a discrepancy between the image name being used by the build and ecr_publish scripts for AMD64 builds. It also adds an --arm64 option to ecr_publish and slightly improves the formatting of script help texts.

Checklist

  • [ ] Added needs-backport label if PR is bug fix that applies to previous minor release
  • Ran scripts/format_code and committed any changes
  • Documentation updated if needed
  • PR has a name that won't get you publicly shamed for vagueness

Notes

N/A

Testing Instructions

  • docker/ecr_publish
  • docker/ecr_publish --arm64
  • docker/ecr_publish --help

@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Merging #1559 (d48d964) into master (1a02e00) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1559      +/-   ##
==========================================
- Coverage   75.78%   75.77%   -0.02%     
==========================================
  Files         193      193              
  Lines        9214     9214              
==========================================
- Hits         6983     6982       -1     
- Misses       2231     2232       +1     
Impacted Files Coverage Δ
...er/dataset/visualizer/classification_visualizer.py 97.36% <0.00%> (-2.64%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@AdeelH AdeelH merged commit b88244c into azavea:master Nov 21, 2022
@AdeelH AdeelH deleted the ecr_pub_img_name branch November 21, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant