Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tutorial notebooks + misc. minor changes #1839

Merged
merged 5 commits into from Jul 21, 2023
Merged

Conversation

AdeelH
Copy link
Collaborator

@AdeelH AdeelH commented Jul 20, 2023

Overview

This PR updates the tutorial notebooks to ensure that they run without errors. See commits for details.

Checklist

  • Added needs-backport label if PR is bug fix that applies to previous minor release
  • Ran scripts/format_code and committed any changes
  • Documentation updated if needed
  • PR has a name that won't get you publicly shamed for vagueness

Notes

N/A

Testing Instructions

Check docs build.

@AdeelH AdeelH force-pushed the nb branch 3 times, most recently from ece15d4 to c740fd7 Compare July 21, 2023 13:20
If env variable AWS_NO_SIGN_REQUEST is set to 'YES', do not attempt to sign in. This is equivalent to passing --no-sign-reuqest to AWS CLI.
- "count" --> "counts"
- add constructor docstring
- set AWS_NO_SIGN_REQUEST env variable in notebooks before accessing S3 URIs
- replace :class/meth:`~a.b.c` with :class/meth:`.c`
- compatibility fixes for shapely 2.0
- misc. minor fixes
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #1839 (2c3748f) into master (f6dcdee) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1839      +/-   ##
==========================================
+ Coverage   80.04%   80.06%   +0.01%     
==========================================
  Files         188      188              
  Lines        9236     9243       +7     
==========================================
+ Hits         7393     7400       +7     
  Misses       1843     1843              
Impacted Files Coverage Δ
...ision_aws_s3/rastervision/aws_s3/s3_file_system.py 94.54% <100.00%> (+0.24%) ⬆️
...astervision_core/rastervision/core/raster_stats.py 99.10% <100.00%> (ø)
...er/dataset/visualizer/classification_visualizer.py 100.00% <100.00%> (ø)

@AdeelH AdeelH marked this pull request as ready for review July 21, 2023 15:48
@AdeelH AdeelH merged commit bff97f3 into azavea:master Jul 21, 2023
2 checks passed
@AdeelH AdeelH deleted the nb branch July 21, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant