Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WiP] SageMaker: Part 1 #1871

Closed
wants to merge 10 commits into from
Closed

Conversation

jamesmcclain
Copy link
Contributor

@jamesmcclain jamesmcclain commented Aug 29, 2023

Overview

Brief description of what this PR does, and why it is needed.

Checklist

  • Added needs-backport label if PR is bug fix that applies to previous minor release
  • Ran scripts/format_code and committed any changes
  • Documentation updated if needed
  • PR has a name that won't get you publicly shamed for vagueness

Notes

Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.

Testing Instructions

  • How to test this PR
  • Prefer bulleted description
  • Start after checking out this branch
  • Include any setup required, such as rebuilding the Docker image.
  • Include test case, and expected output if not captured by automated tests.

Closes #XXX

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #1871 (1740e56) into master (30fd26f) will decrease coverage by 0.36%.
The diff coverage is 33.82%.

@@            Coverage Diff             @@
##           master    #1871      +/-   ##
==========================================
- Coverage   82.49%   82.13%   -0.36%     
==========================================
  Files         190      192       +2     
  Lines        9316     9384      +68     
==========================================
+ Hits         7685     7708      +23     
- Misses       1631     1676      +45     
Files Changed Coverage Δ
...gemaker/rastervision/sagemaker/sagemaker_runner.py 25.00% <25.00%> (ø)
...ision_sagemaker/rastervision/sagemaker/__init__.py 100.00% <100.00%> (ø)

@AdeelH
Copy link
Collaborator

AdeelH commented Oct 31, 2023

Superseded by #1968

@AdeelH AdeelH closed this Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants