Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for VsiFileSystem #1918

Merged
merged 2 commits into from Sep 11, 2023
Merged

Conversation

AdeelH
Copy link
Collaborator

@AdeelH AdeelH commented Sep 8, 2023

Closes #925

@AdeelH AdeelH changed the title Add unit tests for VsiFileSystem Add unit tests for VsiFileSystem Sep 8, 2023
@AdeelH AdeelH added the needs-backport This PR needs to be backported to release branches label Sep 8, 2023
- refactor code
- replace assertions with appropriate exceptions
- replace str.format() with f-strings
- remove docstrings that are identical to parent class
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #1918 (06979b3) into master (91a93c5) will increase coverage by 0.92%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1918      +/-   ##
==========================================
+ Coverage   81.56%   82.48%   +0.92%     
==========================================
  Files         190      190              
  Lines        9287     9313      +26     
==========================================
+ Hits         7575     7682     +107     
+ Misses       1712     1631      -81     
Files Changed Coverage Δ
..._gdal_vsi/rastervision/gdal_vsi/vsi_file_system.py 99.31% <100.00%> (+67.08%) ⬆️

@AdeelH AdeelH merged commit b334d68 into azavea:master Sep 11, 2023
1 of 2 checks passed
@AdeelH AdeelH deleted the vsi_unit_tests branch September 11, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-backport This PR needs to be backported to release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unit tests and docs for VSI file system plugin
2 participants