Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for bbox when saving predictions #1931

Merged
merged 1 commit into from Sep 29, 2023
Merged

Conversation

AdeelH
Copy link
Collaborator

@AdeelH AdeelH commented Sep 29, 2023

Overview

When predictions are made on a cropped RasterSource (i.e. with a bbox specified), that bbox must be accounted for when saving those predictions; otherwise, the georeferencing will be wrong.

Checklist

  • Added needs-backport label if PR is bug fix that applies to previous minor release
  • Ran scripts/format_code and committed any changes
  • Documentation updated if needed
  • PR has a name that won't get you publicly shamed for vagueness

Notes

N/A

Testing Instructions

  • These changes were manually tested. Without these changes the prediction outputs were misaligned with the source imagery. With these changes, they were correctly aligned.

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #1931 (90f2487) into master (1d23e46) will decrease coverage by 0.01%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master    #1931      +/-   ##
==========================================
- Coverage   82.47%   82.47%   -0.01%     
==========================================
  Files         190      190              
  Lines        9325     9330       +5     
==========================================
+ Hits         7691     7695       +4     
- Misses       1634     1635       +1     
Files Coverage Δ
...sion/core/data/label/chip_classification_labels.py 100.00% <100.00%> (ø)
...rvision/core/data/label/object_detection_labels.py 97.12% <100.00%> (ø)
...on/core/data/label/semantic_segmentation_labels.py 91.53% <ø> (ø)
...a/label_store/chip_classification_geojson_store.py 100.00% <ø> (ø)
...data/label_store/object_detection_geojson_store.py 97.14% <ø> (ø)
...n_core/rastervision/core/data/label_store/utils.py 90.00% <100.00%> (ø)
...a/label_store/semantic_segmentation_label_store.py 91.62% <66.66%> (-0.91%) ⬇️

... and 1 file with indirect coverage changes

@AdeelH AdeelH added the needs-backport This PR needs to be backported to release branches label Sep 29, 2023
@AdeelH AdeelH marked this pull request as ready for review September 29, 2023 17:41
@AdeelH AdeelH merged commit ac69538 into azavea:master Sep 29, 2023
2 checks passed
@AdeelH AdeelH deleted the pred-bbox branch September 29, 2023 18:52
AdeelH added a commit to AdeelH/raster-vision that referenced this pull request Oct 16, 2023
Co-authored-by: Adeel Hassan <ahassan@element84.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-backport This PR needs to be backported to release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant