Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a .run_command() method to Runners #1981

Merged
merged 2 commits into from Nov 7, 2023

Conversation

AdeelH
Copy link
Collaborator

@AdeelH AdeelH commented Nov 6, 2023

Overview

This PR adds a .run_command() method to all Runners. The main motivation is to make it easy to run the predict and predict_scene commands remotely.

Checklist

  • Added needs-backport label if PR is bug fix that applies to previous minor release
  • Ran scripts/format_code and committed any changes
  • Documentation updated if needed
  • PR has a name that won't get you publicly shamed for vagueness

Notes

N/A

Testing Instructions

N/A

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #1981 (8aa44e2) into master (ad4743e) will decrease coverage by 0.11%.
The diff coverage is 22.50%.

❗ Current head 8aa44e2 differs from pull request most recent head 0f0ca43. Consider uploading reports for the commit 0f0ca43 to get more accurate results

@@            Coverage Diff             @@
##           master    #1981      +/-   ##
==========================================
- Coverage   86.22%   86.11%   -0.11%     
==========================================
  Files         195      193       -2     
  Lines        9567     9513      -54     
==========================================
- Hits         8249     8192      -57     
- Misses       1318     1321       +3     
Files Coverage Δ
...ision_aws_batch/rastervision/aws_batch/__init__.py 100.00% <ø> (ø)
...e/rastervision/pipeline/runner/inprocess_runner.py 100.00% <100.00%> (ø)
...eline/rastervision/pipeline/runner/local_runner.py 98.36% <100.00%> (+0.05%) ⬆️
...on_pipeline/rastervision/pipeline/runner/runner.py 83.33% <ø> (ø)
...rastervision/aws_sagemaker/aws_sagemaker_runner.py 75.32% <15.38%> (-12.18%) ⬇️
...s_batch/rastervision/aws_batch/aws_batch_runner.py 55.73% <9.09%> (+2.61%) ⬆️

... and 4 files with indirect coverage changes

@AdeelH AdeelH marked this pull request as ready for review November 7, 2023 21:44
@AdeelH AdeelH merged commit cd102da into azavea:master Nov 7, 2023
1 check passed
@AdeelH AdeelH deleted the runner_run_command branch November 17, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant