Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc minor fixes #2053

Merged
merged 5 commits into from Feb 2, 2024
Merged

Misc minor fixes #2053

merged 5 commits into from Feb 2, 2024

Conversation

AdeelH
Copy link
Collaborator

@AdeelH AdeelH commented Feb 2, 2024

Overview

This PR makes miscellaneous minor fixes and improvements. See commits for details.

Checklist

  • Added unit tests, if applicable
  • Updated documentation, if applicable
  • Added needs-backport label if the change should be back-ported to the previous release
  • PR has a name that won't get you publicly shamed for vagueness

Notes

N/A

Testing Instructions

N/A

Previously, this would return a chip composed of the sub raster sources' _get_chip() outputs; now, it will use the sub raster sources' get_chip() outputs. This also means that MultiRasterSource.num_channels_raw == sum of the sub raster sources' num_channels.
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (165c7c3) 85.23% compared to head (61383ac) 85.48%.

❗ Current head 61383ac differs from pull request most recent head 57e95e6. Consider uploading reports for the commit 57e95e6 to get more accurate results

Files Patch % Lines
...data/raster_source/temporal_multi_raster_source.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2053      +/-   ##
==========================================
+ Coverage   85.23%   85.48%   +0.24%     
==========================================
  Files         196      196              
  Lines        9908     9871      -37     
==========================================
- Hits         8445     8438       -7     
+ Misses       1463     1433      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AdeelH AdeelH merged commit 2ed63e3 into azavea:master Feb 2, 2024
2 checks passed
@AdeelH AdeelH deleted the misc-fix branch February 2, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant