Allow passing out_size param to SlidingWindowGeoDataset
#2099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it available to SlidingWindowGeoDataset as well, so that the user does not have to manually create a resize albumentations transform to do this.
AdeelH
force-pushed
the
geodataset-out-size
branch
from
9d43cfc
to
c297c4e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2099 +/- ##
=======================================
Coverage 90.07% 90.07%
=======================================
Files 197 197
Lines 9840 9842 +2
=======================================
+ Hits 8863 8865 +2
Misses 977 977 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR allows an
out_sizeparam to be passed toSlidingWindowGeoDataset.__init__(). This saves the user from having to manually specify an albumentations resize transform. It also makes it more consistent withRandomWindowGeoDataset.__init__().Checklist
needs-backportlabel if the change should be back-ported to the previous releaseNotes
N/A
Testing Instructions
See new unit test.